Auto-include node_stats metricset when xpack.enabled: true is set#20613
Merged
ycombinator merged 11 commits intoelastic:feature-stack-monitoring-mb-ecsfrom Aug 18, 2020
ycombinator:mb-es-xp-node-stats
Merged
Auto-include node_stats metricset when xpack.enabled: true is set#20613ycombinator merged 11 commits intoelastic:feature-stack-monitoring-mb-ecsfrom ycombinator:mb-es-xp-node-stats
ycombinator merged 11 commits intoelastic:feature-stack-monitoring-mb-ecsfrom
ycombinator:mb-es-xp-node-stats
Conversation
Contributor
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
chrisronline
approved these changes
Aug 14, 2020
Contributor
Author
|
CI test failures are relevant. Will investigate and fix. |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Contributor
Author
|
Jenkins CI PR build is green. @sayden would you mind reviewing the PR please? Thanks! |
sayden
approved these changes
Aug 18, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…astic#20613) * Auto-include node_stats metricset when xpack.enabled: true is set * Fixing some tests * Try to fix python system test * Fixing len check * Fixing monitoring index type for node_stats metricset * Account for node_stats docs being indexed into metricbeat-* * Debugging * More debugging * Debugging * Updating integration test * Fixing test code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #19747. A line of code was accidentally removed in #19747. This PR puts it back.
This line of code ensures that when
metricbeat modules enable elasticsearch-xpackis run or, alternatively, when theelasticsearchmodule is enabled and configured withxpack.enabled: true, thenode_statsmetricset is automatically enabled for the module. This will ensure that nothing breaks for existing users of theelasticsearch-xpackmodule.