Cherry-pick #20586 to 7.9: Use older version of github.com/dop251/goja_nodejs#20599
Merged
kvch merged 1 commit intoelastic:7.9from Aug 26, 2020
Merged
Cherry-pick #20586 to 7.9: Use older version of github.com/dop251/goja_nodejs#20599kvch merged 1 commit intoelastic:7.9from
kvch merged 1 commit intoelastic:7.9from
Conversation
(cherry picked from commit b5e0405)
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
|
This pull request doesn't have a |
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
michalpristas
approved these changes
Aug 26, 2020
Contributor
michalpristas
left a comment
There was a problem hiding this comment.
backport looks good
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#20599) (cherry picked from commit 03f4b31)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20586 to 7.9 branch. Original message:
What does this PR do?
This PR pins the version of
github.com/dop251/goja_nodejs.Why is it important?
The recent update of this library leads to the following error when generating custom Beats:
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.