Cherry-pick #20305 to 7.8: [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks#20339
Merged
ChrsMark merged 2 commits intoelastic:7.8from Jul 30, 2020
Merged
Conversation
…fig checks (elastic#20305) (cherry picked from commit 7a34167)
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
|
This pull request doesn't have a |
Contributor
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
jsoriano
approved these changes
Jul 30, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…inished errors in autodiscover config checks (elastic#20339) * [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks (elastic#20305) (cherry picked from commit 8d2bc1f) * Update CHANGELOG.next.asciidoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20305 to 7.8 branch. Original message:
What does this PR do?
This PR ignores
ErrInputNotFinishederror occur in autodiscover stop/start process. This is required in order to avoid having stoped configs that never come back since the start event fails due to this error on first attempt if the previous state is not cleaned yet.Currently configs that fail due to
ErrInputNotFinishedare skipped atbeats/libbeat/autodiscover/autodiscover.go
Line 212 in fb52d26
beats/libbeat/autodiscover/autodiscover.go
Line 223 in fb52d26
beats/libbeat/autodiscover/autodiscover.go
Line 164 in fb52d26
Why is it important?
In order to resolve a permanent issue with updated Pods, which makes Filebeat stop collecting logs after a Pod is updated.
How to test this PR locally
team: qakubectl apply -f <manifest_filename>.yml