Cherry-pick #20138 to 7.8: [Filebeat] Update crowdstrike module#20178
Merged
andrewstucki merged 3 commits intoelastic:7.8from Jul 27, 2020
Merged
Cherry-pick #20138 to 7.8: [Filebeat] Update crowdstrike module#20178andrewstucki merged 3 commits intoelastic:7.8from
andrewstucki merged 3 commits intoelastic:7.8from
Conversation
* Update crowdstrike module (cherry picked from commit 5e9a3a5)
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
marc-gr
approved these changes
Jul 27, 2020
andrewkroh
approved these changes
Jul 27, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
elastic#20178) * [Filebeat] Update crowdstrike module (elastic#20138) * Update crowdstrike module (cherry picked from commit aa58f2e) * Fix up changelog * Fix merge rendering issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20138 to 7.8 branch. Original message:
What does this PR do?
I've been in the crowdstrike module recently anyway and noticed that there was an open issue reporting some parsing errors. I went ahead and just added some fixes for them.
One thing to note--due to normalizing all timestamps to
UNIX_MSthis is technically a breaking change. Do we want to be more conservative about the normalization?Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues