Enable and fix Journalbeat integration tests#20140
Merged
kvch merged 6 commits intoelastic:masterfrom Jul 22, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Log outputExpand to view the last 100 lines of log output
|
Contributor
Author
|
jenkins run tests |
d7bd336 to
40274c4
Compare
Contributor
Author
|
jenkins run tests |
cachedout
approved these changes
Jul 22, 2020
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jul 22, 2020
(cherry picked from commit 2025662)
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jul 22, 2020
(cherry picked from commit 2025662)
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ---------------------- Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
mdelapenya
reviewed
Jul 22, 2020
| for snippet in required_log_snippets: | ||
| self.wait_until(lambda: self.log_contains(snippet), | ||
| name="Line in '{}' Journalbeat log".format(snippet)) | ||
| self.wait_until(lambda: self.output_has(lines=23)) |
Contributor
There was a problem hiding this comment.
I noticed this assertion is different to any of the former ones, and besides that, the changes in other tests are asserting that the output contains "journalbeat is running", is this on purpose?
mdelapenya
reviewed
Jul 22, 2020
| for snippet in required_log_snippets: | ||
| self.wait_until(lambda: self.log_contains(snippet), | ||
| name="Line in '{}' Journalbeat log".format(snippet)) | ||
| self.wait_until(lambda: self.output_has(lines=9)) |
Contributor
There was a problem hiding this comment.
Same here.
Once more thing: how likely is this output to not contain 9 lines?
mdelapenya
reviewed
Jul 22, 2020
| for snippet in required_log_snippets: | ||
| self.wait_until(lambda: self.log_contains(snippet), | ||
| name="Line in '{}' Journalbeat log".format(snippet)) | ||
| self.wait_until(lambda: self.output_has(lines=6)) |
kvch
added a commit
that referenced
this pull request
Jul 29, 2020
kvch
added a commit
that referenced
this pull request
Jul 29, 2020
This was referenced Aug 17, 2020
v1v
added a commit
that referenced
this pull request
Aug 17, 2020
v1v
added a commit
that referenced
this pull request
Aug 17, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…rkers (elastic#20569) (elastic#20582) * [CI] more parallel stages and less provisioned workers (elastic#20569) * Enable and fix Journalbeat integration tests (elastic#20140) * [CI] Fix missing when for Packetbeat (elastic#20626)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.