Skip to content

Cherry-pick #20026 to 7.9: [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd.#20032

Merged
blakerouse merged 1 commit intoelastic:7.9from
blakerouse:backport_20026_7.9
Jul 17, 2020
Merged

Cherry-pick #20026 to 7.9: [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd.#20032
blakerouse merged 1 commit intoelastic:7.9from
blakerouse:backport_20026_7.9

Conversation

@blakerouse
Copy link
Copy Markdown
Contributor

Cherry-pick of PR #20026 to 7.9 branch. Original message:

What does this PR do?

Fixes an issue where the elastic-agent.yml and fleet.yml configurations where being merged, but the merged config was not being used in the Unpack call.

Adds a --staging f32a4a89 option to ./elastic-agent enroll. This allows users that are testing staging builds to be able to pull artifacts from that staging build.

Why is it important?

So elastic-agent.yml and fleet.yml are merged and used correctly. To simplify testing of staging builds.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

 ./elastic_agent enroll --insecure http://localhost:5601 Q1JfZVhITUJsUURwelBhQVB2WVQ6NmlFSVNwZVVSU0tlcVI5dXZNNUtFZw --staging f32a4a89

Related issues

elastic#20026)

* Fix usage of merged elastic-agent.yml and fleet.yml. Add --staging command line option to enroll.

* Add to docs.

* Add changelog.

* Fix import sorting.

(cherry picked from commit cfbd81b)
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 17, 2020
@blakerouse blakerouse self-assigned this Jul 17, 2020
@blakerouse blakerouse merged commit f23ce61 into elastic:7.9 Jul 17, 2020
@blakerouse blakerouse deleted the backport_20026_7.9 branch July 17, 2020 17:15
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
elastic#20026) (elastic#20032)

* Fix usage of merged elastic-agent.yml and fleet.yml. Add --staging command line option to enroll.

* Add to docs.

* Add changelog.

* Fix import sorting.

(cherry picked from commit c84dd9e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants