Skip to content

Cherry-pick #19980 to 7.9: Do not compare err with custom type#19983

Merged
michalpristas merged 1 commit intoelastic:7.9from
michalpristas:backport_19980_7.9
Jul 16, 2020
Merged

Cherry-pick #19980 to 7.9: Do not compare err with custom type#19983
michalpristas merged 1 commit intoelastic:7.9from
michalpristas:backport_19980_7.9

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented Jul 16, 2020

Cherry-pick of PR #19980 to 7.9 branch. Original message:

What does this PR do?

Fixes #19976 by using comparison from errors package instead of comparing custom types

Why is it important?

Avoid panics

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

cc @ph

@michalpristas michalpristas self-assigned this Jul 16, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 16, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 16, 2020
@michalpristas michalpristas changed the title Cherry-pick #19980 to 7.9: Do not compare err with custom type (#19980) Cherry-pick #19980 to 7.9: Do not compare err with custom type Jul 16, 2020
ph
ph approved these changes Jul 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalpristas michalpristas merged commit 03b5b60 into elastic:7.9 Jul 16, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@michalpristas
[Ingest Manager] Do not compare err with custom type (elastic#19980) (e…
6d7e2d3 
…lastic#19983)

* fix error comparison in enroll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ph ph ph approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michalpristas michalpristas

Labels

backport bug Ingest Management:beta1 Group issues for ingest management beta1 review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalpristas @elasticmachine @ph