Skip to content

Cherry-pick #19551 to 7.8: Fix service start type mapping in windows/service metricset#19879

Merged
narph merged 1 commit intoelastic:7.8from
narph:backport_19551_7.8
Jul 15, 2020
Merged

Cherry-pick #19551 to 7.8: Fix service start type mapping in windows/service metricset#19879
narph merged 1 commit intoelastic:7.8from
narph:backport_19551_7.8

Conversation

@narph
Copy link
Copy Markdown
Contributor

@narph narph commented Jul 14, 2020

Cherry-pick of PR #19551 to 7.8 branch. Original message:

What does this PR do?

Fixes start type service mapping.

Why is it important?

Service start type property returned an empty string

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@narph
Fix service start type mapping in windows/service metricset (elastic#…
72c4134 
…19551)

* fit service start type

* test

* changelog

(cherry picked from commit 194be7f)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 14, 2020
@narph narph changed the title Cherry-pick #19551 to 7.x: Fix service start type mapping in windows/service metricset Cherry-pick #19551 to 7.8: Fix service start type mapping in windows/service metricset Jul 14, 2020
@narph narph self-assigned this Jul 14, 2020
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Jul 14, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 14, 2020

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 14, 2020
@narph narph merged commit 9b8be5e into elastic:7.8 Jul 15, 2020
@narph narph deleted the backport_19551_7.8 branch July 15, 2020 09:20
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@narph
Fix service start type mapping in windows/service metricset (elastic#…
32b2b72 
…19551) (elastic#19879)

* fit service start type

* test

* changelog

(cherry picked from commit 262b6f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@narph narph

Labels

backport Team:Integrations Label for the Integrations team [zube]: Done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@narph @elasticmachine @ChrsMark