Close changelog for 7.8.1#19669
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
|
libbeat/docs/release.asciidoc
Outdated
| * <<release-notes-7.0.0-alpha2>> | ||
| * <<release-notes-7.0.0-alpha1>> | ||
| * <<release-notes-6.8.11>> | ||
| * <<release-notes-6.8.10>> |
There was a problem hiding this comment.
Are these sections already in the Changelog.asciidoc? You might need to copy 6.8.10 and 6.8.11 changelog to the 7.8, 7.x, and master branch.
There was a problem hiding this comment.
I suspected something was missing
There was a problem hiding this comment.
Every branch has a different changelog, even the master branch does not have all release notes versions, I will rid of that part
There was a problem hiding this comment.
Every branch has a different changelog
The changelog in each branch must be held consistent. The changelog and documentation is generated from the release branch. This means that 7.8 release branch must include all changelogs for past 7.7, 7.6, 7.5, 7.4, 7.3, 7.2, 7.1, ... 6.8, ... releases
The 7.8 branch will contain all changelogs up to the most recent 7.8.x patch release.
The 7.9 branch will contain all changelogs up to the most recent 7.9.x patch release.
The changelogs in the 7.x and master branch need to be kept in sync with the actual release branches.
If the changelogs in the branches differ, then we're missing the required updates in some branches.
|
@urso can you take a last look to this. |
|
The 7.8.1 changes look good. We still need to add 7.7.1 and old 6.8.10 changelog. The release notes are published here per release branch: https://www.elastic.co/guide/en/beats/libbeat/current/release-notes.html comparing 7.8 and 7.7 or 6.8 branch the notes are currently inconsistent:
The 7.8 branch is missing at least 7.7.1 (which was release before 7.8.0) and there have been added some minor release we're still missing in the changelog. The 7.x and master changelogs also need some cleanup. Do we plan to cleanup the 7.8 changelog in a follow up PR? |
|
@urso We noticed the differences between release notes and the gaps in some of them, we can open an issue for that and fix all the changelogs in a follow-up. So if the changelog in this PR is correct, we could merge it and fix the changelog issues later |
SGTM. Let's do this. |
* Close changelog for 7.8.1 * Update libbeat/docs/release.asciidoc * Update libbeat/docs/release.asciidoc
What does this PR do?
Update Changelogs
Why is it important?
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.