Skip to content

Cherry-pick #19494 to 7.7: Fix tls mapping in suricata module#19607

Merged
leehinman merged 1 commit intoelastic:7.7from
leehinman:backport_19494_7.7
Jul 6, 2020
Merged

Cherry-pick #19494 to 7.7: Fix tls mapping in suricata module#19607
leehinman merged 1 commit intoelastic:7.7from
leehinman:backport_19494_7.7

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

@leehinman leehinman commented Jul 2, 2020

Cherry-pick of PR #19494 to 7.7 branch. Original message:

What does this PR do?

Fixes tls mappings in suricata module. Specifically:

  • add suricata.eve.tls.ja3s.string field
  • add suricata.eve.tls.ja3s.hash field
  • add suricata.eve.tls.ja3.string field
  • add suricata.eve.tls.ja3.hash field
  • set default_field to false for suricata fields
  • map suricata.eve.tls.ja3.hash to tls.client.ja3
  • map suricata.eve.tls.ja3s.hash to tls.server.ja3s
  • perform suricata.eve.tls.* -> tls.* mappings for all event types

Why is it important?

  • If the tls.* mappings aren't filled in the event doesn't show up in
    the TLS tab in the SIEM
  • default_field to false to stay under 1000 fields

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=suricata mage -v pythonIntegTest

Related issues

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 2, 2020
@leehinman leehinman force-pushed the backport_19494_7.7 branch from f730f07 to 1d395f5 Compare July 2, 2020 14:18
* Fix tls mapping in suricata module

- add suricata.eve.tls.ja3s.string field
- add suricata.eve.tls.ja3s.hash field
- add suricata.eve.tls.ja3.string field
- add suricata.eve.tls.ja3.hash field
- set default_field to false for ja3 & ja3s fields
- map suricata.eve.tls.ja3.hash to tls.client.ja3
- map suricata.eve.tls.ja3s.hash to tls.server.ja3s
- perform suricata.eve.tls.* -> tls.* mappings for all event types

Closes elastic#19492

(cherry picked from commit afffe2b)
@leehinman leehinman force-pushed the backport_19494_7.7 branch from 1d395f5 to bfa2bb3 Compare July 6, 2020 00:38
@leehinman
Copy link
Copy Markdown
Contributor Author

run tests

@leehinman leehinman merged commit 4f4baef into elastic:7.7 Jul 6, 2020
@leehinman leehinman deleted the backport_19494_7.7 branch October 5, 2020 19:06
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…c#19607)

* Fix tls mapping in suricata module

- add suricata.eve.tls.ja3s.string field
- add suricata.eve.tls.ja3s.hash field
- add suricata.eve.tls.ja3.string field
- add suricata.eve.tls.ja3.hash field
- set default_field to false for ja3 & ja3s fields
- map suricata.eve.tls.ja3.hash to tls.client.ja3
- map suricata.eve.tls.ja3s.hash to tls.server.ja3s
- perform suricata.eve.tls.* -> tls.* mappings for all event types

Closes elastic#19492

(cherry picked from commit 362016d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants