Skip to content

ci: trigger packages builds only manually or with a comment#19559

Merged
kuisathaverat merged 2 commits intoelastic:masterfrom
kuisathaverat:packaging-ignore-builds
Jul 1, 2020
Merged

ci: trigger packages builds only manually or with a comment#19559
kuisathaverat merged 2 commits intoelastic:masterfrom
kuisathaverat:packaging-ignore-builds

Conversation

@kuisathaverat
Copy link
Copy Markdown
Contributor

What does this PR do?

it puts a filter in place to avoid allocate and agent if the build is not triggered by a comment or a user.

Why is it important?

it avoids waste resources.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kuisathaverat kuisathaverat added enhancement ci Team:Automation Label for the Observability productivity team labels Jul 1, 2020
@kuisathaverat kuisathaverat requested a review from a team July 1, 2020 15:32
@kuisathaverat kuisathaverat self-assigned this Jul 1, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 1, 2020
@v1v v1v changed the title ci: trigger packeges builds only manually or with a comment ci: trigger packages builds only manually or with a comment Jul 1, 2020

pipeline {
agent { label 'ubuntu && immutable' }
agent none
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it work the gitCheckout ?

Copy link
Copy Markdown
Contributor Author

@kuisathaverat kuisathaverat Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it, and it works

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I have launched it on the CI to test it also in the CI https://beats-ci.elastic.co/job/Beats/job/packaging/job/PR-19559/2/console, I'll merge it when it finished

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19559 opened]

  • Start Time: 2020-07-01T15:36:22.860+0000

  • Duration: 51 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 547
Skipped 128
Total 675

@kuisathaverat kuisathaverat merged commit a63eb66 into elastic:master Jul 1, 2020
kuisathaverat added a commit that referenced this pull request Jul 1, 2020
… for the packaging job (#19546)

* ci: correct upstream job

* ci: filter build causes

* Update .ci/packaging.groovy
kuisathaverat added a commit that referenced this pull request Jul 1, 2020
… for the packaging job (#19545)

* ci: correct upstream job

* ci: filter build causes

* Update .ci/packaging.groovy
kuisathaverat added a commit that referenced this pull request Jul 1, 2020
… for the packaging job (#19543)

* ci: correct upstream job

* ci: filter build causes

* Update .ci/packaging.groovy
kuisathaverat added a commit that referenced this pull request Jul 1, 2020
… for the packaging job (#19544)

* ci: filter build causes

* Update .ci/packaging.groovy
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
…19559)

* feat: trigger build only manually or with a comment

* Update .ci/packaging.groovy
@kuisathaverat kuisathaverat deleted the packaging-ignore-builds branch December 24, 2020 11:07
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…trigger on PRs for the packaging job (elastic#19545)

* ci: correct upstream job

* ci: filter build causes

* Update .ci/packaging.groovy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci enhancement Team:Automation Label for the Observability productivity team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants