Skip to content

Use Go install for getting goimports#19535

Merged
kvch merged 2 commits intoelastic:masterfrom
michalpristas:fix-golint
Jul 1, 2020
Merged

Use Go install for getting goimports#19535
kvch merged 2 commits intoelastic:masterfrom
michalpristas:fix-golint

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented Jul 1, 2020 •
edited
Loading

What does this PR do?

ATM when we run go get goimports on CI it modifies go.mod to include latest (daily) version of x/tools
this causes lint to break and results in PR bringing x/tools version up to date in PR fixes

Why is it important?

To avoid failures like this:

diff --git a/go.mod b/go.mod
index 552b28cbb4..f4867e4d91 100644
--- a/go.mod
+++ b/go.mod
@@ -163,7 +163,7 @@ require (
        golang.org/x/sys v0.0.0-20200202164722-d101bd2416d5
        golang.org/x/text v0.3.2
        golang.org/x/time v0.0.0-20191024005414-555d28b269f0
-       golang.org/x/tools v0.0.0-20200626171337-aa94e735be7f
+       golang.org/x/tools v0.0.0-20200630154851-b2d8b0336632
        google.golang.org/api v0.15.0
        google.golang.org/genproto v0.0.0-20191230161307-f3c370f40bfb
        google.golang.org/grpc v1.29.1

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas marked this pull request as ready for review July 1, 2020 08:00
@michalpristas michalpristas self-assigned this Jul 1, 2020
@michalpristas michalpristas requested a review from kvch July 1, 2020 08:00
@michalpristas michalpristas changed the title Use Go modules off for getting goimports Use Go install for getting goimports Jul 1, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 1, 2020 •
edited
Loading

❕ Build Aborted

Either there was a build timeout or someone aborted the build.'}

Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-07-01T10:35:42.050+0000

  • Duration: 122 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 8701
Skipped 1558
Total 10259

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-01T11:09:39.682+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-07-01T12:11:57.982Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-07-01T12:12:14.496Z] Still waiting to schedule task
[2020-07-01T12:12:14.496Z] Waiting for next available executor on ‘macosx’
[2020-07-01T12:37:25.249Z] Cancelling nested steps due to timeout
[2020-07-01T12:37:25.427Z] Stage "Heartbeat Windows" skipped due to earlier failure(s)
[2020-07-01T12:37:25.430Z] Stage "Functionbeat Windows" skipped due to earlier failure(s)
[2020-07-01T12:37:25.433Z] Stage "Generators Beat Mac OS X" skipped due to earlier failure(s)
[2020-07-01T12:37:25.730Z] Failed in branch Heartbeat
[2020-07-01T12:37:25.731Z] Failed in branch Functionbeat
[2020-07-01T12:37:25.732Z] Failed in branch Generators
[2020-07-01T12:37:25.899Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats
[2020-07-01T12:37:26.230Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-07-01T12:37:26.246Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Lint
[2020-07-01T12:37:26.345Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Elastic-Agent-Mac-OS-X
[2020-07-01T12:37:26.431Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-07-01T12:37:26.522Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Winlogbeat-oss
[2020-07-01T12:37:26.622Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-07-01T12:37:26.723Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Filebeat-x-pack-Mac-OS-X
[2020-07-01T12:37:26.825Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Dockerlogbeat
[2020-07-01T12:37:26.921Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Journalbeat-oss
[2020-07-01T12:37:27.015Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-07-01T12:37:27.118Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Filebeat-Mac-OS-X
[2020-07-01T12:37:27.220Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-07-01T12:37:27.321Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Auditbeat-oss-Mac-OS-X
[2020-07-01T12:37:27.414Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-07-01T12:37:27.498Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-07-01T12:37:27.575Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Heartbeat-oss
[2020-07-01T12:37:27.672Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-07-01T12:37:27.761Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-07-01T12:37:27.840Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Libbeat-x-pack
[2020-07-01T12:37:27.921Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Auditbeat-x-pack-Windows
[2020-07-01T12:37:28.003Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Auditbeat-oss-Windows
[2020-07-01T12:37:28.090Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-07-01T12:37:28.185Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Filebeat-x-pack-Windows
[2020-07-01T12:37:28.265Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Auditbeat-oss-Linux
[2020-07-01T12:37:28.354Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Packetbeat-oss
[2020-07-01T12:37:28.436Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Filebeat-Windows
[2020-07-01T12:37:28.515Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-07-01T12:37:28.607Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-Windows
[2020-07-01T12:37:28.705Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Filebeat-x-pack
[2020-07-01T12:37:28.798Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Filebeat-oss
[2020-07-01T12:37:28.878Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-07-01T12:37:29.084Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-07-01T12:37:29.185Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Auditbeat-x-pack-Mac-OS-X
[2020-07-01T12:37:29.267Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Libbeat-oss
[2020-07-01T12:37:29.344Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-x-pack-Mac-OS-X
[2020-07-01T12:37:29.421Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-Mac-OS-X
[2020-07-01T12:37:29.502Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Libbeat-crosscompile
[2020-07-01T12:37:29.582Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Libbeat-stress-tests
[2020-07-01T12:37:29.657Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-07-01T12:37:29.732Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-07-01T12:37:29.810Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-07-01T12:37:30.180Z] + cat
[2020-07-01T12:37:30.180Z] + /usr/local/bin/runbld ./runbld-script
[2020-07-01T12:37:30.180Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-07-01T12:37:36.778Z] runbld>>> runbld started
[2020-07-01T12:37:36.778Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-07-01T12:37:39.329Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-19535' in order of occurrence in the config (last value wins).
[2020-07-01T12:37:40.272Z] runbld>>> Debug logging enabled.
[2020-07-01T12:37:40.272Z] runbld>>> Storing result
[2020-07-01T12:37:40.533Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-07-01T12:37:40.533Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200701123740-627D8958
[2020-07-01T12:37:40.533Z] runbld>>> Adding system facts.
[2020-07-01T12:37:41.479Z] runbld>>> Adding vcs info for the latest commit:  573597ddcb78d6c7f6d415eec8c1c506020c29da
[2020-07-01T12:37:41.479Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-07-01T12:37:41.479Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-07-01T12:37:41.479Z] + echo 'Processing JUnit reports with runbld...'
[2020-07-01T12:37:41.479Z] Processing JUnit reports with runbld...
[2020-07-01T12:37:42.053Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-07-01T12:37:42.053Z] runbld>>> DURATION: 25ms
[2020-07-01T12:37:42.053Z] runbld>>> STDOUT: 40 bytes
[2020-07-01T12:37:42.053Z] runbld>>> STDERR: 49 bytes
[2020-07-01T12:37:42.053Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-07-01T12:37:42.053Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats
[2020-07-01T12:37:42.999Z] runbld>>> Storing build metadata: 
[2020-07-01T12:37:42.999Z] runbld>>> Adding test report.
[2020-07-01T12:37:43.000Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats
[2020-07-01T12:37:43.946Z] runbld>>> Found 107 test output files
[2020-07-01T12:37:44.522Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-07-01T12:37:44.522Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-07-01T12:37:44.785Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-07-01T12:37:44.785Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-07-01T12:37:44.785Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-07-01T12:37:44.785Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-07-01T12:37:44.785Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-07-01T12:37:46.177Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 10109 Skipped: 1321
[2020-07-01T12:37:46.178Z] runbld>>> Storing result
[2020-07-01T12:37:46.178Z] runbld>>> FAILURES: 0
[2020-07-01T12:37:46.439Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-07-01T12:37:46.439Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200701123740-627D8958
[2020-07-01T12:37:46.439Z] runbld>>> Email notification disabled by environment variable.
[2020-07-01T12:37:46.439Z] runbld>>> Slack notification disabled by environment variable.
[2020-07-01T12:37:52.116Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19535
[2020-07-01T12:37:52.222Z] [INFO] getVaultSecret: Getting secrets
[2020-07-01T12:37:52.312Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-01T12:37:53.125Z] + chmod 755 generate-build-data.sh
[2020-07-01T12:37:53.125Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19535/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19535/runs/4 ABORTED 7330816
[2020-07-01T12:37:53.125Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19535/runs/4/steps/?limit=10000 -o steps-info.json
[2020-07-01T12:37:55.608Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19535/runs/4/tests/?status=FAILED -o tests-errors.json
[2020-07-01T12:37:56.161Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19535/runs/4/log/ -o pipeline-log.txt

@kvch kvch merged commit 9619361 into elastic:master Jul 1, 2020
@jsoriano jsoriano mentioned this pull request Jul 1, 2020
Merged
6 tasks
michalpristas added a commit to michalpristas/beats that referenced this pull request Jul 1, 2020
@michalpristas
Use Go install for getting goimports (elastic#19535)
836a343 
* go get off mode

* use go install
@michalpristas michalpristas mentioned this pull request Jul 1, 2020
Merged
6 tasks
michalpristas added a commit that referenced this pull request Jul 1, 2020
@michalpristas
Use Go install for getting goimports (#19535) (#19542)
e39b335 
Use Go install for getting goimports (#19535) (#19542)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@michalpristas @melchiormoulin
Use Go install for getting goimports (elastic#19535)
f1f7d18 
* go get off mode

* use go install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

+1 more reviewer

@kvch kvch kvch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michalpristas michalpristas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michalpristas @elasticmachine @jsoriano @kvch