Skip to content

Implement storage handling for cursor inputs#19518

Merged
urso merged 1 commit intoelastic:masterfrom
urso:input-v2-cursor-store
Jul 1, 2020
Merged

Implement storage handling for cursor inputs#19518
urso merged 1 commit intoelastic:masterfrom
urso:input-v2-cursor-store

Conversation

@urso
Copy link
Copy Markdown

@urso urso commented Jun 30, 2020

  • Enhancement

What does this PR do?

This change provide the store implementation that is used by the cursor
input to track ephemeral and persistent state.

The full list of changes will include:

Why is it important?

Implement support for statefull inputs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    ~~- [ ] I have made corresponding change to the default configuration files~~~~
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

go test

Related issues

@urso urso added review Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Project:Filebeat-Input-v2 Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0 labels Jun 30, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 30, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 30, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 30, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19518 updated]

  • Start Time: 2020-07-01T12:33:58.347+0000

  • Duration: 29 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 547
Skipped 127
Total 674

This change provide the store implementation that is used by the cursor
input to track ephemeral and persistent state.

The full list of changes will include:
- Introduce v2 API interfaces
- Introduce [compatibility layer](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/input/v2/compat) to integrate API with existing functionality
- Introduce helpers for writing [stateless](https://github.com/urso/beats/blob/fb-input-v2-combined/filebeat/input/v2/input-stateless/stateless.go) inputs.
- Introduce helpers for writing [inputs that store a state](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/input/v2/input-cursor) between restarts.
- Integrate new API with [existing inputs and modules](https://github.com/urso/beats/blob/fb-input-v2-combined/filebeat/beater/filebeat.go#L301) in filebeat.
@urso urso force-pushed the input-v2-cursor-store branch from a8d85d8 to 1f30d8e Compare July 1, 2020 11:57
@urso
Copy link
Copy Markdown
Author

urso commented Jul 1, 2020

Packaging is currently broken in other PRs as well due to mage missing. Beats tests have been green.

@urso urso merged commit 0800ab1 into elastic:master Jul 1, 2020
@urso urso deleted the input-v2-cursor-store branch July 1, 2020 13:05
@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Jul 8, 2020
urso pushed a commit to urso/beats that referenced this pull request Jul 8, 2020
This change provide the store implementation that is used by the cursor
input to track ephemeral and persistent state.

The full list of changes will include:
- Introduce v2 API interfaces
- Introduce [compatibility layer](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/input/v2/compat) to integrate API with existing functionality
- Introduce helpers for writing [stateless](https://github.com/urso/beats/blob/fb-input-v2-combined/filebeat/input/v2/input-stateless/stateless.go) inputs.
- Introduce helpers for writing [inputs that store a state](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/input/v2/input-cursor) between restarts.
- Integrate new API with [existing inputs and modules](https://github.com/urso/beats/blob/fb-input-v2-combined/filebeat/beater/filebeat.go#L301) in filebeat.

(cherry picked from commit 0800ab1)
urso pushed a commit that referenced this pull request Jul 8, 2020
…plement storage handling for cursor inputs (#19732)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
This change provide the store implementation that is used by the cursor
input to track ephemeral and persistent state.

The full list of changes will include:
- Introduce v2 API interfaces
- Introduce [compatibility layer](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/input/v2/compat) to integrate API with existing functionality
- Introduce helpers for writing [stateless](https://github.com/urso/beats/blob/fb-input-v2-combined/filebeat/input/v2/input-stateless/stateless.go) inputs.
- Introduce helpers for writing [inputs that store a state](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/input/v2/input-cursor) between restarts.
- Integrate new API with [existing inputs and modules](https://github.com/urso/beats/blob/fb-input-v2-combined/filebeat/beater/filebeat.go#L301) in filebeat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Filebeat Filebeat Project:Filebeat-Input-v2 review skip-test-plan Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants