Get stats for all indices, including hidden indices#18703
Merged
ycombinator merged 7 commits intoelastic:masterfrom Jul 6, 2020
ycombinator:mb-es-xp-index-hidden
Merged
Get stats for all indices, including hidden indices#18703ycombinator merged 7 commits intoelastic:masterfrom ycombinator:mb-es-xp-index-hidden
ycombinator merged 7 commits intoelastic:masterfrom
ycombinator:mb-es-xp-index-hidden
Conversation
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
6 tasks
Contributor
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
jsoriano
reviewed
Jul 1, 2020
Member
jsoriano
left a comment
There was a problem hiding this comment.
LGTM, added a question about getting stats now for closed indices too, I guess we are ok with that, but just in case. Maybe we need to mention closed indices also in the changelog.
Contributor
Author
|
@jsoriano I've addressed your review feedback regarding closed indices. This PR is ready for re-review, when you get a chance. Thanks! |
jsoriano
approved these changes
Jul 6, 2020
Contributor
Author
|
CI failures are unrelated. Merging. |
ycombinator
added a commit
that referenced
this pull request
Jul 8, 2020
* Get stats for all indices * Update default stack versions to use in integration tests * Add integration test for hidden indices stats * Better naming of variables * Adding CHANGELOG entry * Use expand_wildcards in tests as well * Collect stats for open and hidden indices (but not closed ones)
6 tasks
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* Get stats for all indices * Update default stack versions to use in integration tests * Add integration test for hidden indices stats * Better naming of variables * Adding CHANGELOG entry * Use expand_wildcards in tests as well * Collect stats for open and hidden indices (but not closed ones)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
elasticsearch/indexmetricset to collect metrics for all indices, including hidden ones.Why is it important?
With the introduction of hidden indices in Elasticsearch (elastic/elasticsearch#50452), the
GET _statsAPI call, by default, does not return stats for hidden indices. So it needs to be enhanced to request stats for all indices.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues