Cherry-pick #18086 to 7.x: Fix metricbeat generator test to use mage test#18208
Merged
blakerouse merged 1 commit intoelastic:7.xfrom May 5, 2020
Merged
Cherry-pick #18086 to 7.x: Fix metricbeat generator test to use mage test#18208blakerouse merged 1 commit intoelastic:7.xfrom
blakerouse merged 1 commit intoelastic:7.xfrom
Conversation
* Use mage unit-test. * Should be make. * Update mage test. * Add PackageKibanaDashboardsFromBuildDir. (cherry picked from commit 9e7321a)
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
andrewkroh
approved these changes
May 4, 2020
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Member
|
I think there's a flaw with these tests. It looks like the test generates code from this PR's commit (as it should) but it always pulls in the generated Beat's vendor from "origin/master". |
Contributor
Author
|
@andrewkroh Yes because of go mods the generated beat always uses |
Member
|
It seems like we need a way to be able to test against the same code that's under test (populate the generated beat's vendor with commit under test). Otherwise you can never be confident that the merged changes are good. Even if we only test on master you'd still have this problem. |
Contributor
Author
|
@andrewkroh being that issue still affects master, I am going to merge this so 7.x and master are the same in this regard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18086 to 7.x branch. Original message:
What does this PR do?
Updates the generated custom metricbeat to use
mage testinstead ofmake unit.Why is it important?
So the generator tests pass.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.