Skip to content

Fix dashboards export test#17768

Merged
jsoriano merged 6 commits intoelastic:masterfrom
jsoriano:fix-test-dashboards-error-message
Apr 20, 2020
Merged

Fix dashboards export test#17768
jsoriano merged 6 commits intoelastic:masterfrom
jsoriano:fix-test-dashboards-error-message

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Apr 16, 2020 •
edited by ycombinator
Loading

Test is checking an error message from Kibana that has changed.

Fixes this issue currently affecting master:

Traceback (most recent call last):
  File "/usr/lib/python3.7/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/usr/lib/python3.7/unittest/case.py", line 615, in run
    testMethod()
  File "/go/src/github.com/elastic/beats/libbeat/tests/system/test_dashboard.py", line 191, in test_export_dashboard_cmd_export_dashboard_by_id_unknown_id
    assert self.log_contains("error exporting dashboard: Not found") is True
AssertionError

Co-Authored-By: Andrew Kroh andrew.kroh@elastic.co

Resolves #17827.

@jsoriano
Fix dashboards export test
4270b25 
Test is checking an error message from Kibana that has changed.
@jsoriano jsoriano self-assigned this Apr 16, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 16, 2020

Pinging @elastic/integrations (Team:Integrations)

@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented Apr 16, 2020

I have seen that commands tested here print stack traces when fail, I have created another issue as follow up: #17769

@jsoriano jsoriano mentioned this pull request Apr 16, 2020
Merged
6 tasks
andrewkroh
andrewkroh reviewed Apr 17, 2020
View reviewed changes
andrewkroh
andrewkroh approved these changes Apr 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented Apr 17, 2020

jenkins, test this again

@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented Apr 20, 2020 •
edited
Loading

Errors in CI with kafka images should be solved by #17828 #17819

@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented Apr 20, 2020

Trying again after #17819

@jsoriano jsoriano merged commit 8c9391c into elastic:master Apr 20, 2020
@jsoriano jsoriano deleted the fix-test-dashboards-error-message branch April 20, 2020 16:12
@kvch kvch mentioned this pull request May 8, 2020
Merged
@kvch kvch added the v7.9.0 label May 8, 2020
kvch pushed a commit to kvch/beats that referenced this pull request May 8, 2020
@jsoriano @kvch
Fix dashboards export test (elastic#17768)
3d6c442 
Test is checking an error message from Kibana that has changed.
(cherry picked from commit 8c9391c)
kvch pushed a commit to kvch/beats that referenced this pull request May 8, 2020
@jsoriano @kvch
Fix dashboards export test (elastic#17768)
9922644 
Test is checking an error message from Kibana that has changed.
(cherry picked from commit 8c9391c)
@kvch kvch mentioned this pull request May 8, 2020
Merged
@kvch kvch added the v7.8.0 label May 8, 2020
kvch added a commit that referenced this pull request May 8, 2020
@kvch @jsoriano
Fix dashboards export test (#17768) (#18373)
3de9879 
Test is checking an error message from Kibana that has changed.
(cherry picked from commit 8c9391c)

Co-authored-by: Jaime Soriano Pastor <jsorianopastor@gmail.com>
kvch added a commit that referenced this pull request May 8, 2020
@kvch @jsoriano
Fix dashboards export test (#17768) (#18372)
fb361a7 
Test is checking an error message from Kibana that has changed.
(cherry picked from commit 8c9391c)

Co-authored-by: Jaime Soriano Pastor <jsorianopastor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@jsoriano jsoriano

Labels

libbeat review Team:Integrations Label for the Integrations team :Testing v7.8.0 v7.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test: test_dashboard.Test.test_export_dashboard_cmd_export_dashboard_by_id_unknown_id

5 participants

@jsoriano @elasticmachine @andrewkroh @andresrc @kvch