CEF CheckPoint: adjust fields for forward compatibility#17681
Merged
adriansr merged 10 commits intoelastic:masterfrom Apr 14, 2020
Merged
CEF CheckPoint: adjust fields for forward compatibility#17681adriansr merged 10 commits intoelastic:masterfrom
adriansr merged 10 commits intoelastic:masterfrom
Conversation
We're trying to consolidate the field names under checkpoint.* and file_hash is not an existing field. This removes the field and keeps the data in the appropriate ECS field. Also adds support for SHA-256, which the checkpoint supports, but it's not documented in the CEF exporter.
This renames / changes types on some custom fields under checkpoint to align with the names used in Check Point logs (not CEF), so that the documents generated by the CEF module and the upcoming checkpoint module are compatible.
That's the correct name for this field.
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
P1llus
reviewed
Apr 13, 2020
Member
P1llus
left a comment
There was a problem hiding this comment.
Added some comments, rest looks good to me!
filebeat/docs/fields.asciidoc
Outdated
| Protection performance impact. | ||
|
|
||
| type: keyword | ||
| type: long |
filebeat/docs/fields.asciidoc
Outdated
| Confidence level determined. | ||
|
|
||
| type: keyword | ||
| type: long |
Member
There was a problem hiding this comment.
This type should be changed to integer
andrewkroh
approved these changes
Apr 14, 2020
| Confidence level determined. | ||
|
|
||
| type: keyword | ||
| type: integer |
Member
There was a problem hiding this comment.
Is is this already a number in the event produced by the beat? Looks like it should be since it comes from deviceFlexNumber1 which is a long from the cef processor.
6 tasks
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Apr 14, 2020
This PR makes some changes to CEF module's custom mappings for Check Point devices to ensure compatibility with the upcoming checkpoint module. Check Point has its custom log format, for which a new module is being prepared. The idea behind this new module as well as CEF custom mappings for Check Point (this PR), is to use ECS whenever possible and map the rest under checkpoint.* using the original field name from Check Point. In the original PR for CEF, a few mistakes had been done in field names and types. Also taking the opportunity to change some ECS mappings. Related elastic#16907 elastic#17682 (cherry picked from commit 4f6da4f)
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Apr 14, 2020
This PR makes some changes to CEF module's custom mappings for Check Point devices to ensure compatibility with the upcoming checkpoint module. Check Point has its custom log format, for which a new module is being prepared. The idea behind this new module as well as CEF custom mappings for Check Point (this PR), is to use ECS whenever possible and map the rest under checkpoint.* using the original field name from Check Point. In the original PR for CEF, a few mistakes had been done in field names and types. Also taking the opportunity to change some ECS mappings. Related elastic#16907 elastic#17682 (cherry picked from commit 4f6da4f)
6 tasks
adriansr
added a commit
that referenced
this pull request
Apr 15, 2020
) This PR makes some changes to CEF module's custom mappings for Check Point devices to ensure compatibility with the upcoming checkpoint module. Check Point has its custom log format, for which a new module is being prepared. The idea behind this new module as well as CEF custom mappings for Check Point (this PR), is to use ECS whenever possible and map the rest under checkpoint.* using the original field name from Check Point. In the original PR for CEF, a few mistakes had been done in field names and types. Also taking the opportunity to change some ECS mappings. Related #16907 #17682 (cherry picked from commit 4f6da4f)
adriansr
added a commit
that referenced
this pull request
Apr 15, 2020
) This PR makes some changes to CEF module's custom mappings for Check Point devices to ensure compatibility with the upcoming checkpoint module. Check Point has its custom log format, for which a new module is being prepared. The idea behind this new module as well as CEF custom mappings for Check Point (this PR), is to use ECS whenever possible and map the rest under checkpoint.* using the original field name from Check Point. In the original PR for CEF, a few mistakes had been done in field names and types. Also taking the opportunity to change some ECS mappings. Related #16907 #17682 (cherry picked from commit 4f6da4f)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… (elastic#17712) This PR makes some changes to CEF module's custom mappings for Check Point devices to ensure compatibility with the upcoming checkpoint module. Check Point has its custom log format, for which a new module is being prepared. The idea behind this new module as well as CEF custom mappings for Check Point (this PR), is to use ECS whenever possible and map the rest under checkpoint.* using the original field name from Check Point. In the original PR for CEF, a few mistakes had been done in field names and types. Also taking the opportunity to change some ECS mappings. Related elastic#16907 elastic#17682 (cherry picked from commit ddb92ca)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes some changes to CEF module's custom mappings for Check Point devices, to ensure compatibility with the upcoming checkpoint module.
Check Point has its custom log format, for which a new module is being prepared. The idea behind this new module as well as CEF custom mappings for Check Point (this PR), is to use ECS whenever possible and map the rest under
checkpoint.*using the original field name from Check Point.In the original PR for CEF, a few mistakes had been done in field names and types. Also taking the opportunity to change some ECS mappings.
Why is it important?
We want both CEF an checkpoint modules to define and populate the same fields, ECS and proprietary, and avoid having a breaking change in the future.
Checklist
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc. Not needed, feature is unreleased.Relates [SIEM][CEF] Add support for Check Point devices #16907 Checkpoint Syslog Filebeat module #17682