Skip to content

fix: login into the docker registry#17620

Merged
kuisathaverat merged 3 commits intoelastic:masterfrom
kuisathaverat:fix-docker-login
Apr 14, 2020
Merged

fix: login into the docker registry#17620
kuisathaverat merged 3 commits intoelastic:masterfrom
kuisathaverat:fix-docker-login

Conversation

@kuisathaverat
Copy link
Copy Markdown
Contributor

What does this PR do?

  • it does docker login into the elastic registry

Why is it important?

we use some Docker images from that registry, so we need to login in it.

Copy link
Copy Markdown
Contributor

@mikemadden42 mikemadden42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuisathaverat
Copy link
Copy Markdown
Contributor Author

kuisathaverat commented Apr 13, 2020

if we make a docker pull we can pull the image but the command cd x-pack/metricbeat;mage update build test cannot pull the image, I will track it down but it is weird. BTW something happens on the packer cache the image is not in the worker, because of that I think it starts failing.

@kuisathaverat
Copy link
Copy Markdown
Contributor Author

the workers image build is broken for 6 days

@kuisathaverat kuisathaverat force-pushed the fix-docker-login branch 3 times, most recently from b9370d6 to 5e92736 Compare April 13, 2020 16:26
@kuisathaverat kuisathaverat merged commit c072a24 into elastic:master Apr 14, 2020
@kuisathaverat kuisathaverat deleted the fix-docker-login branch April 14, 2020 07:55
This was referenced Apr 20, 2020
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Apr 28, 2020
* fix: login into the docker registry

* test: make a pull after login to test

* docs: add note to the workaround
jsoriano added a commit that referenced this pull request Apr 28, 2020
Backport some features added to Jenkinsfile to 7.x branch:
* Dry run option.
* Docker login.
* Git config for generator tests.
* Filter changes using go list.

These are the cherry-picked changes:
* fix: login into the docker registry (#17620)
* feat: filter changes using go list output (#17397)
* fix: disable workaround on macos (#17750)
* ci: set git user configuration if it is not set (#17782)
* fix: mount Docker credentials (#17798)
* Review dependency patterns collection in Jenkins (#18004)

Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants