[Filebeat] Unix stream socket input source#17492
Merged
andrewstucki merged 17 commits intoelastic:masterfrom Apr 21, 2020
Merged
[Filebeat] Unix stream socket input source#17492andrewstucki merged 17 commits intoelastic:masterfrom
andrewstucki merged 17 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
added 2 commits
April 3, 2020 22:25
added 8 commits
April 3, 2020 22:38
andrewkroh
reviewed
Apr 13, 2020
Member
andrewkroh
left a comment
There was a problem hiding this comment.
This looks great! Just a few minor comments.
Author
|
Looks like the test failure is unrelated: |
6 tasks
andrewstucki
pushed a commit
to andrewstucki/beats
that referenced
this pull request
Apr 21, 2020
* initial common refactor * Fix up unix and add license info * Fix inputs * Clean up handlers * Update changelog and docs * Fix added input * Fix tests * Add unix socket system tests * add systems tests for syslog unix input * pep autoformat * Disable unix tests for Windows since Python 3.8 doesn't support AF_UNIX * pep autoformat * Address feedback * fix test (cherry picked from commit 3b99438)
andrewstucki
pushed a commit
that referenced
this pull request
Apr 21, 2020
…#17851) * [Filebeat] Unix stream socket input source (#17492) * initial common refactor * Fix up unix and add license info * Fix inputs * Clean up handlers * Update changelog and docs * Fix added input * Fix tests * Add unix socket system tests * add systems tests for syslog unix input * pep autoformat * Disable unix tests for Windows since Python 3.8 doesn't support AF_UNIX * pep autoformat * Address feedback * fix test (cherry picked from commit 3b99438) * Fix changelog
Member
|
@andrewstucki Can you please follow-up on this PR with three things:
|
This was referenced Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds Unix stream socket support as an input source.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues