Skip to content

Cherry-pick #17334 to 7.7: Add test for documented fields check for metricsets without a http input#17438

Merged
narph merged 2 commits intoelastic:7.7from
narph:backport_17334_7.7
Apr 6, 2020
Merged

Cherry-pick #17334 to 7.7: Add test for documented fields check for metricsets without a http input#17438
narph merged 2 commits intoelastic:7.7from
narph:backport_17334_7.7

Conversation

@narph
Copy link
Copy Markdown
Contributor

@narph narph commented Apr 2, 2020

Cherry-pick of PR #17334 to 7.7 branch. Original message:

What does this PR do?

Adds a test to check that the metricset fields are documented based on the events generated in the integration tests.

Why is it important?

This is a step in the requirements for moving modules/metricsets to GA.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Add mbtest.TestMetricsetFieldsDocumented to the integration test

Related issues

narph added 2 commits April 2, 2020 16:02
…put (elastic#17334)

* add test for documented fields

* changelog

* work on test

* add test for testdata

* fmt update

(cherry picked from commit e545836)
@narph narph self-assigned this Apr 2, 2020
@narph narph added backport Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Apr 2, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations (Team:Integrations)

Copy link
Copy Markdown
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@narph narph merged commit 564c974 into elastic:7.7 Apr 6, 2020
@narph narph deleted the backport_17334_7.7 branch April 6, 2020 10:00
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…k for metricsets without a http input (elastic#17438)

* Add test for documented fields check for metricsets without a http input (elastic#17334)

* add test for documented fields

* changelog

* work on test

* add test for testdata

* fmt update

(cherry picked from commit 072f28e)

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Metricbeat Metricbeat Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants