Fix _id field in s3 and googlepubsub inputs#17026
Merged
andrewkroh merged 1 commit intoelastic:masterfrom Mar 18, 2020
Merged
Conversation
In elastic#15859 the Elasticsearch output was changed to read from the @metadata._id field when it had been using @metadata.id. The s3 and googlepubsub inputs had both been setting @metadata.id, but were not updated with that change. This updates the s3 and googlepubsub inputs to use `beat.Event#SetID()` rather than creating the metadata object themselves.
cf754bf to
c656da4
Compare
kaiyan-sheng
approved these changes
Mar 18, 2020
Contributor
kaiyan-sheng
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing the s3 input part!
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Mar 19, 2020
In elastic#15859 the Elasticsearch output was changed to read from the @metadata._id field when it had been using @metadata.id. The s3 and googlepubsub inputs had both been setting @metadata.id, but were not updated with that change. This updates the s3 and googlepubsub inputs to use `beat.Event#SetID()` rather than creating the metadata object themselves. (cherry picked from commit 304eca4)
andrewkroh
added a commit
that referenced
this pull request
Mar 19, 2020
In #15859 the Elasticsearch output was changed to read from the @metadata._id field when it had been using @metadata.id. The s3 and googlepubsub inputs had both been setting @metadata.id, but were not updated with that change. This updates the s3 and googlepubsub inputs to use `beat.Event#SetID()` rather than creating the metadata object themselves. (cherry picked from commit 304eca4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In #15859 the Elasticsearch output was changed to read from the @metadata._id field when it had been using @metadata.id. The s3 and googlepubsub inputs had both been setting @metadata.id, but were not updated with that change.
This updates the s3 and googlepubsub inputs to use
beat.Event#SetID()rather than creating the metadata object themselves.Why is it important?
These inputs rely on the Elasticsearch
_idfield to prevent duplicate events from being written to Elasticsearch in certain edge cases.Related issues