Fix issue where autodiscover hints default configuration was not being copied.#16987
Merged
blakerouse merged 3 commits intoelastic:masterfrom Mar 13, 2020
Merged
Fix issue where autodiscover hints default configuration was not being copied.#16987blakerouse merged 3 commits intoelastic:masterfrom
blakerouse merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
ChrsMark
reviewed
Mar 13, 2020
Member
ChrsMark
left a comment
There was a problem hiding this comment.
It looks good @blakerouse ! I only left a question regarding the comments that were added, feel free to correct me!
jsoriano
reviewed
Mar 13, 2020
Member
jsoriano
left a comment
There was a problem hiding this comment.
Great investigation @blakerouse! Change looks good and safe.
Do you think we could add a test case that reproduces this issue and checks that multiple configs don't interfere one with each other?
Contributor
Author
ChrsMark
approved these changes
Mar 13, 2020
2 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Mar 13, 2020
…g copied. (elastic#16987) * Fix issue where autodiscover hints default configuration was not being copied. * Add changelog. * Add test and update comment. (cherry picked from commit 661ff14)
2 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Mar 13, 2020
…g copied. (elastic#16987) * Fix issue where autodiscover hints default configuration was not being copied. * Add changelog. * Add test and update comment. (cherry picked from commit 661ff14)
blakerouse
added a commit
that referenced
this pull request
Mar 13, 2020
… configuration was not being copied. (#17003) * Fix issue where autodiscover hints default configuration was not being copied. (#16987) * Fix issue where autodiscover hints default configuration was not being copied. * Add changelog. * Add test and update comment. (cherry picked from commit 661ff14) * Fix import to remove v7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FIxes issue where when a default configuration is provided to autodiscovery in filebeat it would cause the elasticsearch module to have log messages repeated and appear in different datasets.
Why is it important?
Without this change log messages would be repeated and reported in different datasets unless
hints.default_config.enabled: falsewas set. Which also prevented filebeat from reading the logs of pods that didn't have the annotation ofco.elastic.logs/enabled: true.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksHow to test this PR locally
cd filebeat && PACKAGES="linux/amd64" mage packageevent.dataset.Related issues
Use cases
Screenshots
Logs