Fix k8s pod labels tier in metadata#16480
Merged
ChrsMark merged 4 commits intoelastic:masterfrom Feb 25, 2020
Merged
Conversation
Signed-off-by: chrismark <chrismarkou92@gmail.com>
mtojek
reviewed
Feb 21, 2020
| } | ||
|
|
||
| out := p.resource.Generate("pod", obj, opts...) | ||
| // TODO: remove this call when moving to 8.0 |
Contributor
There was a problem hiding this comment.
I thinks it's fair to create an issue for removing this TODO ;)
Contributor
There was a problem hiding this comment.
+1, that said. I'm not quite convinced this is the way to go. Let's move this fix forward and discuss future steps in the opened issue
| return nil | ||
| } | ||
|
|
||
| func (p *pod) fixLabels(in common.MapStr) common.MapStr { |
Contributor
There was a problem hiding this comment.
Hmm.. "fix" says nothing about the behavior. Could you rename this method to sth less vague? movePodLabels, extractPodLabel, etc.
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ea32ee1 to
1f4d866
Compare
4 tasks
mtojek
approved these changes
Feb 21, 2020
Contributor
|
LGTM, Let's move this one forward, it seems some tests are failing, we need to update some tests cases |
Member
Author
|
Test cases were fixed. Also added a changelog. |
exekias
approved these changes
Feb 25, 2020
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Feb 25, 2020
(cherry picked from commit 837279a)
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Feb 25, 2020
(cherry picked from commit 837279a)
This was referenced Feb 25, 2020
ChrsMark
added a commit
that referenced
this pull request
Feb 25, 2020
ChrsMark
added a commit
that referenced
this pull request
Feb 25, 2020
This was referenced Feb 25, 2020
This was referenced Mar 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16464
Description of bug investigation: #16464 (comment)
cc: @exekias