Use JSON string for dictionary example#15898
Merged
jsoriano merged 1 commit intoelastic:feature/python3from Jan 28, 2020
Merged
Use JSON string for dictionary example#15898jsoriano merged 1 commit intoelastic:feature/python3from
jsoriano merged 1 commit intoelastic:feature/python3from
Conversation
Some versions of python cannot guarantee order of dictionaries, so same dictionary can generate different documentation strings. Use a JSON string so its representation doesn't depend on how python encodes it. Also, fix versions in python-env for root directory.
63 tasks
Member
Author
|
jenkins, test this please |
andrewkroh
approved these changes
Jan 28, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Some versions of python cannot guarantee order of dictionaries, so same dictionary can generate different documentation strings. Use a JSON string so its representation doesn't depend on how python encodes it. Also, fix versions in python-env for root directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some versions of python cannot guarantee order of dictionaries, so same
dictionary can generate different documentation strings, and this makes
make checkto fail in some python 3 versions.Use a JSON string so its representation doesn't depend on how python
encodes it.
Also, fix versions in python-env for root directory.