Try to fix flakiness of appsearch system tests#15878
Merged
jsoriano merged 5 commits intoelastic:feature/python3from Jan 28, 2020
Merged
Try to fix flakiness of appsearch system tests#15878jsoriano merged 5 commits intoelastic:feature/python3from
jsoriano merged 5 commits intoelastic:feature/python3from
Conversation
63 tasks
mtojek
reviewed
Jan 27, 2020
mtojek
approved these changes
Jan 27, 2020
Contributor
mtojek
left a comment
There was a problem hiding this comment.
Feel free to merge this PR if it removes flakiness.
Member
Author
|
No luck. I am going to try to revert the memory change and if I cannot solve it in travis I will skip the test. |
Member
Author
|
I think that the failures at this point are being caused by builds in travis taking significative longer. |
Member
Author
|
In any case I would like to merge this change, it fixes issues at least in local, and shows the output of nosetests, what I find helpful (and will be consistent with the equivalent change we did for go tests in #14839). |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Use the health check of the service for the docker health check, and check the status code of the response. Print nosetests output on builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test fails quite frequently in python 3 builds in Travis #14798, and much
less frequently in other builds. Try to address this flakiness.