Use 'python3 -m venv' instead of virtualenv#15754
Merged
jsoriano merged 4 commits intoelastic:feature/python3from Jan 24, 2020
Merged
Use 'python3 -m venv' instead of virtualenv#15754jsoriano merged 4 commits intoelastic:feature/python3from
jsoriano merged 4 commits intoelastic:feature/python3from
Conversation
jsoriano
reviewed
Jan 22, 2020
Member
jsoriano
left a comment
There was a problem hiding this comment.
I think we should also replace the virtualenv calls in the Makefile in the root directory and the one in generator/common/Makefile.
Member
Author
|
I'll check that out. I found a few more direct calls to |
Switch over to `python3 -m venv` instead of `virtualenv`. It's the recommended way to create virtual Python environments in 3.4 and above. https://docs.python.org/3/library/venv.html
Remove any direct references to python to always allow a specific python binary or version to be used.
2d113a1 to
06153c3
Compare
63 tasks
Member
|
It seems that we need to install |
Member
Author
|
Oh yeah..., Debian has split up the python distribution so you need that package to get the venv module. Will add that. |
5 tasks
kvch
approved these changes
Jan 24, 2020
Member
|
Merging this, thanks! |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Switch over to `python3 -m venv` instead of `virtualenv`. It's the recommended way to create virtual Python environments in 3.4 and above. https://docs.python.org/3/library/venv.html Remove any direct references to python to always allow a specific python binary or version to be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch over to
python3 -m venvinstead ofvirtualenv. It's the recommended way to create virtual Python environments in 3.4 and above.https://docs.python.org/3/library/venv.html