Fix mapping and race condition in sql module#15738
Merged
jsoriano merged 6 commits intoelastic:masterfrom Jan 22, 2020
Merged
Conversation
Mapping was defined at the metricset level, but it should be defined at the module level. Add system test to earlier check documented fields. Fixes elastic#15736
exekias
reviewed
Jan 22, 2020
metricbeat/docs/fields.asciidoc
Outdated
| + | ||
| -- | ||
| Non-numeric values collected. | ||
| Non-numeric values collected. - release: beta |
Member
Author
There was a problem hiding this comment.
Yep, I have needed a while to find the proper combination of spaces in the yamls, it should be fixed now.
Prometheus and statsd modules have the same problem, I will open a different PR to fix them.
Member
Author
There was a problem hiding this comment.
PR for the same change in other modules #15742
exekias
approved these changes
Jan 22, 2020
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jan 22, 2020
Mapping was defined at the metricset level, but it should be defined at the module level. Add system test to earlier detect this kind of issues. Also add validation so driver and sql_query options cannot be empty. Fetch was reusing some maps when building the event, what was causing mixed data in events and panics on queries with lots of rows. Fixes elastic#15736 (cherry picked from commit badb2cb)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jan 22, 2020
Mapping was defined at the metricset level, but it should be defined at the module level. Add system test to earlier detect this kind of issues. Also add validation so driver and sql_query options cannot be empty. Fetch was reusing some maps when building the event, what was causing mixed data in events and panics on queries with lots of rows. Fixes elastic#15736 (cherry picked from commit badb2cb)
jsoriano
added a commit
that referenced
this pull request
Jan 22, 2020
Mapping was defined at the metricset level, but it should be defined at the module level. Add system test to earlier detect this kind of issues. Also add validation so driver and sql_query options cannot be empty. Fetch was reusing some maps when building the event, what was causing mixed data in events and panics on queries with lots of rows. Fixes #15736 (cherry picked from commit badb2cb)
jsoriano
added a commit
that referenced
this pull request
Jan 23, 2020
Mapping was defined at the metricset level, but it should be defined at the module level. Add system test to earlier detect this kind of issues. Also add validation so driver and sql_query options cannot be empty. Fetch was reusing some maps when building the event, what was causing mixed data in events and panics on queries with lots of rows. Fixes #15736 (cherry picked from commit badb2cb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mapping was defined at the metricset level, but it should be defined at
the module level.
Add system test to earlier detect this kind of issues.
Also add validation so driver and sql_query options cannot be empty.
Fetch was reusing some maps when building the event, what was
causing mixed data in events and panics on queries with lots of rows.
Fixes #15736