Read hits.total.value to get number of hits#15728
Merged
andrewkroh merged 1 commit intoelastic:feature/python3from Jan 22, 2020
Merged
Read hits.total.value to get number of hits#15728andrewkroh merged 1 commit intoelastic:feature/python3from
andrewkroh merged 1 commit intoelastic:feature/python3from
Conversation
This should fix test_management.py under Python3. An object was being returned but the test was expecting to get a number. The format of the Elasticsearch response changed for the "track_total_hits" enhancement, but this wasn't updated.
63 tasks
jsoriano
approved these changes
Jan 22, 2020
Member
jsoriano
left a comment
There was a problem hiding this comment.
Thanks! x-pack libbeat build goes to green with this change 🚀
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
This should fix test_management.py under Python3. An object was being returned but the test was expecting to get a number. The format of the Elasticsearch response changed for the "track_total_hits" enhancement, but this wasn't updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix test_management.py under Python3. An object was being returned but
the test was expecting to get a number. The format of the Elasticsearch response changed
for the "track_total_hits" enhancement, but this wasn't updated.