[Elastic Log Driver] Add redis and kafka outputs#15719
Merged
fearful-symmetry merged 3 commits intoelastic:masterfrom Jan 23, 2020
Merged
[Elastic Log Driver] Add redis and kafka outputs#15719fearful-symmetry merged 3 commits intoelastic:masterfrom
fearful-symmetry merged 3 commits intoelastic:masterfrom
Conversation
exekias
reviewed
Jan 23, 2020
sayden
approved these changes
Jan 23, 2020
Contributor
sayden
left a comment
There was a problem hiding this comment.
Agree with Carlos. I also think that tests could come in a follow up PR to keep things moving
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Jan 23, 2020
* add redis and kafka out * add cloud output * add changelog (cherry picked from commit 1820369)
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Jan 23, 2020
* add redis and kafka out * add cloud output * add changelog (cherry picked from commit 1820369)
fearful-symmetry
added a commit
that referenced
this pull request
Jan 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I noticed that for some reason this isn't enabled. I'm not sure if this is a bug or enhancement, but I think we should have it in 7.6, as the rest of the beats have this and so should we.
I'm also not sure if anything is needed to get the cloud output working. Anyone know?