Add keep-backport-label in cherry_pick script#15680
Merged
ChrsMark merged 3 commits intoelastic:masterfrom Jan 23, 2020
Merged
Conversation
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Contributor
|
I like the idea of letting users decide if the label should be removed or not. However, it would be better if the default behaviour would not change. Meaning the label would be removed by default, unless e.g. |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
kvch
approved these changes
Jan 22, 2020
Contributor
|
One more thing: please update the PR description with the changes. |
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Jan 23, 2020
(cherry picked from commit 9bdbf91)
5 tasks
ChrsMark
added a commit
that referenced
this pull request
Jan 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a
keep-backport-labelin cherry_pick script. If this flag is set then the labelneeds_backportof the original PR will be preserved.Why is it important?
In many cases we want to backport to more than one branches so removing the label by default for any backporting action may remove label even if the backports are not completed yet.
Checklist
I tested this manually with #15535 and it works.
@jsoriano @kvch what do you think about this?