Cherry-pick #15557 to 7.5: Fix convert processor conversion of string with leading zeros to integer#15567
Merged
adriansr merged 1 commit intoelastic:7.5from Jan 15, 2020
Merged
Conversation
…ger (elastic#15557) The conversion failed when for strings with leading zeroes and a decimal digit 8 or 9, as the underlying runtime function would try to parse that as an octal number. This is fixed by only allowing decimal and hex, which in turns makes the processor more aligned to its Elasticsearch counterpart. Fixes elastic#15513 (cherry picked from commit e0071b5)
33a2cfd to
8b4c28d
Compare
odacremolbap
approved these changes
Jan 15, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ger (elastic#15557) (elastic#15567) The conversion failed when for strings with leading zeroes and a decimal digit 8 or 9, as the underlying runtime function would try to parse that as an octal number. This is fixed by only allowing decimal and hex, which in turns makes the processor more aligned to its Elasticsearch counterpart. Fixes elastic#15513 (cherry picked from commit e26a260)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #15557 to 7.5 branch. Original message:
The conversion failed when for strings with leading zeros and a decimal digit 8 or 9, as the underlying runtime function would try to parse that as an octal number.
This is fixed by only allowing decimal and hex, which in turns makes the processor more aligned to its Elasticsearch counterpart.
Fixes #15513