Skip to content

Fix make check for python 3#15226

Merged
mikemadden42 merged 2 commits intoelastic:feature/python3from
mikemadden42:autopep-update_golang_x
Dec 20, 2019
Merged

Fix make check for python 3#15226
mikemadden42 merged 2 commits intoelastic:feature/python3from
mikemadden42:autopep-update_golang_x

Conversation

@mikemadden42
Copy link
Copy Markdown
Contributor

@mikemadden42 mikemadden42 commented Dec 19, 2019

make check works fine on Ubuntu 18.04 after this fix.

@kvch
Copy link
Copy Markdown
Contributor

kvch commented Dec 19, 2019

It does not seem to fix the build. :(

@mikemadden42
Copy link
Copy Markdown
Contributor Author

mikemadden42 commented Dec 19, 2019

Thanks @kvch . I'm guessing you're referring to the travis-ci jobs?

I wonder if this is an issue with an older Python in Travis CI? @jsoriano Is there a minimum python 3.x that we're targeting?

DEPRECATION: Python 3.4 support has been deprecated. pip 19.1 will be the last one supporting it. Please upgrade your Python as Python 3.4 won't be maintained after March 2019 (cf PEP 429).

@mikemadden42
Copy link
Copy Markdown
Contributor Author

mikemadden42 commented Dec 19, 2019

I wonder if we need to update the version of Ubuntu used for our travis-ci jobs. We're using Ubuntu 14.04 (Trusty) which looks like it ships with Python 3.4. We may need to switch to Ubuntu 16.04 (Xenial) or 18.04 (Bionic). I've been doing my testing on Ubuntu 18.04.

$ grep ^dist .travis.yml
dist: trusty

@mikemadden42 mikemadden42 changed the title Run autopep on script/update_golang_x.py to fix make check Fix make check for python 3 Dec 19, 2019
@mikemadden42
Copy link
Copy Markdown
Contributor Author

mikemadden42 commented Dec 20, 2019

@kvch @jsoriano make check is passing in the latest travis build for this PR.

https://travis-ci.org/elastic/beats/builds/627459709

@jsoriano jsoriano mentioned this pull request Dec 20, 2019
Merged
63 tasks
jsoriano
jsoriano approved these changes Dec 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If travis likes it, I like it!

I wonder if this is an issue with an older Python in Travis CI? @jsoriano Is there a minimum python 3.x that we're targeting?

We haven't decided a minimum version to support, but in any case we shouldn't care about deprecated or unmaintained versions, so no worries if this doesn't work with Python 3.4.

There was a point about upgrading python, or the base image in Travis in #14798, I have added this PR as fix for that.

@mikemadden42
Copy link
Copy Markdown
Contributor Author

mikemadden42 commented Dec 20, 2019

There are around 11 failures unrelated to make check in the last travis build. It would be nice to investigate these.

https://travis-ci.org/elastic/beats/builds/627459709

@mikemadden42 mikemadden42 merged commit b9629f9 into elastic:feature/python3 Dec 20, 2019
@mikemadden42 mikemadden42 deleted the autopep-update_golang_x branch December 20, 2019 14:05
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@mikemadden42
Fix make check for python 3 (elastic#15226)
caf91d0 
* Run autopep on script/update_golang_x.py to fix make check
* Update travis to use Ubuntu Bionic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

@kvch kvch Awaiting requested review from kvch

Assignees

No one assigned

Labels

refactoring review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikemadden42 @kvch @jsoriano