Skip to content

[Winlogbeat] ignore message field in security unit tests#15197

Merged
leehinman merged 1 commit intoelastic:masterfrom
leehinman:process_created_2012
Dec 20, 2019
Merged

[Winlogbeat] ignore message field in security unit tests#15197
leehinman merged 1 commit intoelastic:masterfrom
leehinman:process_created_2012

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

  • different versions of Windows populate the message field differently
    so ignore them in the unit tests
  • updated golden files also include host.name

Fixes #15195

@leehinman leehinman added Winlogbeat needs_backport PR is waiting to be backported to other branches. Team:SIEM labels Dec 18, 2019
@leehinman leehinman requested review from andrewkroh and ph December 18, 2019 21:42
@leehinman leehinman requested a review from a team as a code owner December 18, 2019 21:42
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/siem (Team:SIEM)

@leehinman
Copy link
Copy Markdown
Contributor Author

jenkins, test this

- different versions of Windows populate the message field differently
  so ignore them in the unit tests
- updated golden files also include host.name

Fixes elastic#15195
@leehinman leehinman force-pushed the process_created_2012 branch from 4a83a1d to c4568e1 Compare December 20, 2019 15:10
@leehinman
Copy link
Copy Markdown
Contributor Author

jenkins, test this

@leehinman leehinman merged commit 586eac1 into elastic:master Dec 20, 2019
leehinman added a commit to leehinman/beats that referenced this pull request Jan 2, 2020
- different versions of Windows populate the message field differently
  so ignore them in the unit tests
- updated golden files also include host.name

Fixes elastic#15195

(cherry picked from commit 586eac1)
@leehinman leehinman added v7.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 2, 2020
leehinman added a commit that referenced this pull request Jan 3, 2020
…5311)

- different versions of Windows populate the message field differently
  so ignore them in the unit tests
- updated golden files also include host.name

Fixes #15195

(cherry picked from commit 586eac1)
@leehinman leehinman deleted the process_created_2012 branch March 27, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Winlogbeat]TestSecurity/security-windows2019_4688_Process_Created.evtx failing on win2012r2

3 participants