Skip to content

Allow console output to make local debugging easier#15143

Merged
ycombinator merged 1 commit intoelastic:masterfrom
ycombinator:fnb-console-output
Dec 20, 2019
Merged

Allow console output to make local debugging easier#15143
ycombinator merged 1 commit intoelastic:masterfrom
ycombinator:fnb-console-output

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented Dec 17, 2019

Normally it doesn't make much sense to have the console output enabled for Functionbeat. However, when using a tool such as sam (with the AWS provider) for testing local changes or debugging locally, it's very convenient to enable the console output.

For this reason, this PR adds support for the console output in Functionbeat.

It is worth noting that we do not document the console output in our online docs, so supporting it should not become a source of confusion for end users of Functionbeat. For the same reason, I am not including a CHANGELOG entry in this PR either.

Copy link
Copy Markdown
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph
Copy link
Copy Markdown
Contributor

ph commented Dec 19, 2019

@ycombinator good PR description, I love that! 👍

@ycombinator
Copy link
Copy Markdown
Contributor Author

Travis CI is green. Jenkins CI failures are unrelated. Merging.

@ycombinator ycombinator merged commit eb8c1f6 into elastic:master Dec 20, 2019
@ycombinator ycombinator deleted the fnb-console-output branch December 20, 2019 13:53
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Jan 15, 2020
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants