Allow console output to make local debugging easier#15143
Merged
ycombinator merged 1 commit intoelastic:masterfrom Dec 20, 2019
ycombinator:fnb-console-output
Merged
Allow console output to make local debugging easier#15143ycombinator merged 1 commit intoelastic:masterfrom ycombinator:fnb-console-output
ycombinator merged 1 commit intoelastic:masterfrom
ycombinator:fnb-console-output
Conversation
Contributor
|
@ycombinator good PR description, I love that! 👍 |
Contributor
Author
|
Travis CI is green. Jenkins CI failures are unrelated. Merging. |
ycombinator
added a commit
that referenced
this pull request
Jan 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally it doesn't make much sense to have the
consoleoutput enabled for Functionbeat. However, when using a tool such assam(with the AWS provider) for testing local changes or debugging locally, it's very convenient to enable theconsoleoutput.For this reason, this PR adds support for the
consoleoutput in Functionbeat.It is worth noting that we do not document the
consoleoutput in our online docs, so supporting it should not become a source of confusion for end users of Functionbeat. For the same reason, I am not including a CHANGELOG entry in this PR either.