Migrate Filebeat integration tests to Python3#15030
Merged
kvch merged 5 commits intoelastic:feature/python3from Dec 13, 2019
Merged
Migrate Filebeat integration tests to Python3#15030kvch merged 5 commits intoelastic:feature/python3from
kvch merged 5 commits intoelastic:feature/python3from
Conversation
63 tasks
jsoriano
reviewed
Dec 11, 2019
Member
jsoriano
left a comment
There was a problem hiding this comment.
Thanks! All good, but I think we shouldn't explicitly call to python3 in virtualenvs, python should already be the good one.
libbeat/scripts/Makefile
Outdated
| @# Update docs | ||
| @mkdir -p docs | ||
| @${PYTHON_ENV}/bin/python ${ES_BEATS}/libbeat/scripts/generate_fields_docs.py $(PWD)/fields.yml ${BEAT_TITLE} ${ES_BEATS} | ||
| @${PYTHON_ENV}/bin/python3 ${ES_BEATS}/libbeat/scripts/generate_fields_docs.py $(PWD)/fields.yml ${BEAT_TITLE} ${ES_BEATS} |
Member
There was a problem hiding this comment.
I think this shouldn't be needed, the python environment should have only the correct python binary in bin/python.
jsoriano
approved these changes
Dec 12, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.