Skip to content

Make independent python virtualenvs in docker#14903

Merged
jsoriano merged 2 commits intoelastic:feature/python3from
jsoriano:isolated-python-env-dockerfiles
Dec 3, 2019
Merged

Make independent python virtualenvs in docker#14903
jsoriano merged 2 commits intoelastic:feature/python3from
jsoriano:isolated-python-env-dockerfiles

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Dec 3, 2019

System tests running in docker are using the same virtual environment as
the host. If version of python in the virtual environment is not available
in the guest, it will use the default in the system, that is so far
Python 2.

Also install Python 3 in the dockers, and Pillow, that was needed on my
system when running locally.

System tests running in docker are using the same virtual environment as
the host. If version of python in the virtual environment is not available
in the guest, it will use the default in the system, that is so far
Python 2.
@jsoriano jsoriano requested a review from kvch December 3, 2019 11:06
@jsoriano jsoriano requested a review from a team as a code owner December 3, 2019 11:06
@jsoriano jsoriano self-assigned this Dec 3, 2019
@jsoriano jsoriano mentioned this pull request Dec 3, 2019
63 tasks
@jsoriano jsoriano merged commit 360d5e1 into elastic:feature/python3 Dec 3, 2019
@jsoriano jsoriano deleted the isolated-python-env-dockerfiles branch December 3, 2019 12:36
@andrewkroh
Copy link
Copy Markdown
Member

As a slight optimization the VE setup by mage goes into build/ to avoid re-building it each time.

https://github.com/elastic/beats/blob/master/dev-tools/mage/pytest.go#L235

I guess the Make portion doesn’t separate the VE’s into build/ve/{os} for us.

leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
System tests running in docker are using the same virtual environment as
the host. If version of python in the virtual environment is not available
in the guest, it will use the default in the system, that is so far
Python 2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants