Cisco: Add warning about script compilations to docs#14789
Merged
adriansr merged 2 commits intoelastic:masterfrom Nov 27, 2019
Merged
Cisco: Add warning about script compilations to docs#14789adriansr merged 2 commits intoelastic:masterfrom
adriansr merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
benskelker
approved these changes
Nov 26, 2019
benskelker
left a comment
There was a problem hiding this comment.
LGTM
@dedemorton do you want to take a look?
dedemorton
reviewed
Nov 26, 2019
Contributor
dedemorton
left a comment
There was a problem hiding this comment.
Added a couple of suggestions, but overall looks great.
filebeat/docs/modules/cisco.asciidoc
Outdated
| on your cluster: | ||
|
|
||
| - {ref}/circuit-breaker.html#script-compilation-circuit-breaker[script.max_compilations_rate]: | ||
| Increase the default value of `75/5m` to at least `100/5m`. |
Contributor
There was a problem hiding this comment.
Might be best to avoid mentioning the default here because defaults change over time, and this info is likely to get stale.
Contributor
There was a problem hiding this comment.
Just to clarify... I mean that the ES docs should be the source of truth for ES defaults. We probably shouldn't mention them in the Beats docs if we can avoid it.
Contributor
Author
There was a problem hiding this comment.
makes complete sense, thanks
filebeat/docs/modules/cisco.asciidoc
Outdated
| Increase the default value of `75/5m` to at least `100/5m`. | ||
|
|
||
| - {ref}/modules-scripting-using.html#modules-scripting-using-caching[script.cache_max_size]: | ||
| Increase the default value of `100` to at least `200` if using both filesets |
Contributor
There was a problem hiding this comment.
same comment about defaults
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Jan 16, 2020
The cisco/asa and cisco/ftd filesets can cause problems with the default script compilation settings in Elasticsearch. This PR adds a warning about it to the docs and some workarounds. (cherry picked from commit 629b2eb)
adriansr
added a commit
that referenced
this pull request
Jan 17, 2020
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Jan 17, 2020
The cisco/asa and cisco/ftd filesets can cause problems with the default script compilation settings in Elasticsearch. This PR adds a warning about it to the docs and some workarounds. (cherry picked from commit 629b2eb)
adriansr
added a commit
that referenced
this pull request
Jan 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cisco/asa and cisco/ftd filesets can cause problems with the default script compilation settings in Elasticsearch. This PR adds a warning about it to the docs and some workarounds.