Skip to content

[ILM] Remove beat version from default policy name.#14745

Merged
simitt merged 3 commits intoelastic:masterfrom
simitt:14736-ilm-policy-no-version
Nov 26, 2019
Merged

[ILM] Remove beat version from default policy name.#14745
simitt merged 3 commits intoelastic:masterfrom
simitt:14736-ilm-policy-no-version

Conversation

@simitt
Copy link
Copy Markdown
Contributor

@simitt simitt commented Nov 25, 2019

Prevent breaking customized ILM policies on upgrade, by getting rid of
the version in the default policy name. The version can still be
configured.

fixes #14736

Prevent breaking customized ILM policies on upgrade, by getting rid of
the version in the default policy name. The version can still be
configured.

fixes elastic#14736
@simitt simitt requested a review from urso November 25, 2019 13:35
@urso urso self-assigned this Nov 25, 2019
@urso urso added the review label Nov 25, 2019
@urso
Copy link
Copy Markdown

urso commented Nov 25, 2019

Change LGTM. Code linter fails on python formatting.

@simitt simitt added the Team:apm APM Server team issues/PRs label Nov 26, 2019
@simitt
Copy link
Copy Markdown
Contributor Author

simitt commented Nov 26, 2019

Same test failing as in master. @urso please approve when you are fine with the changes so I can merge.

@urso
Copy link
Copy Markdown

urso commented Nov 26, 2019

Approved. Can you please add a changelog entry to breaking changes in Changelog.next.asciidoc before merging? No need to wait for CI. All tests have been green.

@simitt simitt merged commit 84b9d2a into elastic:master Nov 26, 2019
simitt added a commit to simitt/beats that referenced this pull request Nov 26, 2019
Prevent breaking customized ILM policies on upgrade, by getting rid of
the version in the default policy name. The version can still be manuaylly
configured.

fixes elastic#14736
simitt added a commit that referenced this pull request Nov 28, 2019
Prevent breaking customized ILM policies on upgrade, by getting rid of
the version in the default policy name. The version can still be manuaylly
configured.

fixes #14736
@simitt simitt added test-plan Add this PR to be manual test plan v7.6.0 Team:Beats labels Jan 20, 2020
@urso urso removed their assignment Jan 20, 2020
@urso
Copy link
Copy Markdown

urso commented Jan 21, 2020

Tested:

  • Default ILM policy has no version. OK
  • Customizing ILM policy name works. OK
  • Add agent version to costum ILM policy name works. OK
  • Check documentation does not mention that agent version is set by default. FAIL
  • Check reference configuration file does not mention that agent version is set by default. FAIL

The change works as expected, but documentation + reference configuration files still need to be updated. I will create a PR doing so.

@urso urso added the test-plan-regression Manually testing this PR found a regression label Jan 21, 2020
@urso
Copy link
Copy Markdown

urso commented Jan 22, 2020

Doc fix available in #15750

@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
@simitt simitt deleted the 14736-ilm-policy-no-version branch August 4, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change release-highlight review Team:apm APM Server team issues/PRs Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan test-plan-ok This PR passed manual testing v7.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove versions from ILM policies

3 participants