Skip to content

[Winlogbeat] Set host.name to computername#14625

Merged
leehinman merged 3 commits intoelastic:masterfrom
leehinman:13920_setting_hosts
Nov 20, 2019
Merged

[Winlogbeat] Set host.name to computername#14625
leehinman merged 3 commits intoelastic:masterfrom
leehinman:13920_setting_hosts

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

  • set host.name to computer name for windows events and sysmon

Fixes #13706

Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend mentioning in the commit description that this will depend on a change to libbeat, #14407, to allow the host.name value to pass through without be overwritten.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-Set host.name to computername in Windows event logs & sysmon. {issue}13706[13706]
- Set host.name to computername in Windows event logs & sysmon. {issue}13706[13706]

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/siem (Team:SIEM)

@leehinman leehinman marked this pull request as ready for review November 19, 2019 21:30
@leehinman leehinman requested a review from a team as a code owner November 19, 2019 21:30
@leehinman leehinman added the needs_backport PR is waiting to be backported to other branches. label Nov 19, 2019
@leehinman leehinman merged commit da6dd9d into elastic:master Nov 20, 2019
leehinman added a commit to leehinman/beats that referenced this pull request Nov 21, 2019
* Set host.name to computername

 - set host.name to computer name for windows events and sysmon
 - Add info about libbeat elastic#14407 dependency

Fixes elastic#13706

(cherry picked from commit da6dd9d)
@leehinman leehinman added v7.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 21, 2019
leehinman added a commit that referenced this pull request Nov 21, 2019
* Set host.name to computername

 - set host.name to computer name for windows events and sysmon
 - Add info about libbeat #14407 dependency

Fixes #13706

(cherry picked from commit da6dd9d)
@leehinman leehinman deleted the 13920_setting_hosts branch March 27, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[winlogbeat] Use the original host for host.name in Windows Event Logs

3 participants