[7.5] Log monitoring bulk failures (#14356)#14527
Merged
ycombinator merged 7 commits intoelastic:7.5from Nov 19, 2019
ycombinator:backport/7.5/pr-14356
Merged
[7.5] Log monitoring bulk failures (#14356)#14527ycombinator merged 7 commits intoelastic:7.5from ycombinator:backport/7.5/pr-14356
ycombinator merged 7 commits intoelastic:7.5from
ycombinator:backport/7.5/pr-14356
Conversation
* Log monitoring bulk failures * Renaming function * Simplifying type * Removing extraneous second value * Adding godoc comments * Adding CHANGELOG entry * Clarifying log messages * WIP: adding unit test stubs * Fleshing out unit tests
ph
approved these changes
Nov 19, 2019
Contributor
ph
left a comment
There was a problem hiding this comment.
LGTM, except the changelog need to be fixed.
| - Limit some of the error messages to the logs only {issue}14317[14317] {pull}14327[14327] | ||
| - Fix cloudwatch metricset with names and dimensions in config. {issue}14376[14376] {pull}14391[14391] | ||
| - Fix marshaling of ms-since-epoch values in `elasticsearch/cluster_stats` metricset. {pull}14378[14378] | ||
| - Log bulk failures from bulk API requests to monitoring cluster. {issue}14303[14303] {pull}14356[14356] |
Contributor
Author
There was a problem hiding this comment.
Argh, yes, thanks!
Contributor
There was a problem hiding this comment.
@ycombinator still an issue ? one day 🤖 will take care of it.
* Log monitoring bulk failures * Renaming function * Simplifying type * Removing extraneous second value * Adding godoc comments * Adding CHANGELOG entry * Clarifying log messages * WIP: adding unit test stubs * Fleshing out unit tests
…into backport/7.5/pr-14356
ph
approved these changes
Nov 19, 2019
Contributor
Author
|
Travis CI is green and Jenkins CI failures are unrelated. Merging. |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Log monitoring bulk failures (elastic#14356) * Log monitoring bulk failures * Renaming function * Simplifying type * Removing extraneous second value * Adding godoc comments * Adding CHANGELOG entry * Clarifying log messages * WIP: adding unit test stubs * Fleshing out unit tests * [DOCS] Deprecate central management (elastic#14104) (elastic#14594) * State minimum Go version (elastic#14400) (elastic#14598) * [DOCS] Fix description of rename processor (elastic#14408) (elastic#14600) * Log monitoring bulk failures (elastic#14356) * Log monitoring bulk failures * Renaming function * Simplifying type * Removing extraneous second value * Adding godoc comments * Adding CHANGELOG entry * Clarifying log messages * WIP: adding unit test stubs * Fleshing out unit tests * Fixing up CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.5: