Typeconv package#14144
Merged
urso merged 3 commits intoelastic:feature-new-registry-filefrom Oct 25, 2019
Merged
Conversation
houndci-bot
reviewed
Oct 18, 2019
houndci-bot
reviewed
Oct 18, 2019
Merged
ph
approved these changes
Oct 23, 2019
Contributor
ph
left a comment
There was a problem hiding this comment.
changes lgtm, there are a few hound comments to fix.
This was referenced Oct 24, 2019
urso
pushed a commit
that referenced
this pull request
Nov 21, 2019
Move type conversion support to parse arbitrary go types into common.MapStr (and other types) from the memlog registry to libbeat for reuse.
urso
pushed a commit
that referenced
this pull request
Jan 16, 2020
Move type conversion support to parse arbitrary go types into common.MapStr (and other types) from the memlog registry to libbeat for reuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move type conversion support to parse arbitrary go types into common.MapStr (and other types) from the memlog registry to libbeat for reuse.