[Heartbeat] Remove host.name field from events#14140
[Heartbeat] Remove host.name field from events#14140andrewvc merged 4 commits intoelastic:masterfrom
Conversation
This field should never have been present, and is a distraction from the observer.* fields. Resolves elastic#12107
|
Pinging @elastic/uptime (:uptime) |
ruflin
left a comment
There was a problem hiding this comment.
Definitively needs a changelog as a breaking change.
|
|
||
| func init() { | ||
| RootCmd = cmd.GenRootCmdWithSettings(beater.New, instance.Settings{Name: Name}) | ||
| settings := instance.Settings{ |
There was a problem hiding this comment.
Don't remember anymore the full affect of this. Does it only remove the host.* name fields or any other fields too?
There was a problem hiding this comment.
This should just remove the default host.name field. In comparison to this line, which I think the default for a beat, the difference is just the lack of WithHost.
There was a problem hiding this comment.
That's my understanding as well
|
@ruflin thanks for the review! Added the CHANGELOG entry, also cleaned up some imports I missed the first time. |
ruflin
left a comment
There was a problem hiding this comment.
LGTM, but please check CI.
|
@ruflin CI failures are unrelated |
This field should never have been present, and is a distraction from the observer.* fields. Resolves elastic#12107
This field should never have been present, and is a distraction from the
observer.* fields.
Resolves #12107