Skip to content

[DOCS] Updates links to Stack Overview#14121

Merged
lcawl merged 1 commit intoelastic:masterfrom
lcawl:fix-stack-urls
Oct 29, 2019
Merged

[DOCS] Updates links to Stack Overview#14121
lcawl merged 1 commit intoelastic:masterfrom
lcawl:fix-stack-urls

Conversation

@lcawl
Copy link
Copy Markdown
Member

@lcawl lcawl commented Oct 17, 2019

This PR updates or removes links from the Beats books to the Stack Overview in the cases where the content has moved to a new location.

Deleted pages exist in the Stack Overview and redirects will be created by the web team, but it seems wise to fix these links at the source in master.

@lcawl lcawl requested a review from dedemorton October 17, 2019 20:43
@lcawl lcawl requested a review from a team as a code owner October 17, 2019 20:43
@dedemorton
Copy link
Copy Markdown
Contributor

@lcawl Let's wait on this until the PR that's already open is reviewed and merged: #14028

Then if I've missed anything, we can fix it.

@dedemorton
Copy link
Copy Markdown
Contributor

@lcawl Note that I've backported #14028 to the 7.4 and 7.5 branches. I don't plan to backport to earlier branches. You might want to cherry-pick your original changes into 7.3 and earlier before rebasing this PR.

Copy link
Copy Markdown
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the monitoring team perspective, these changes look fine. (I'm reviewing since we got tagged on it.)

Copy link
Copy Markdown
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The docs CI test passed, so you're good to merge. (The other CI failures are not related to your changes, so you can ignore.

Copy link
Copy Markdown
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The docs CI test passed, so you're good to merge. (The other CI failures are not related to your changes, so you can ignore.

@lcawl lcawl merged commit b2f316f into elastic:master Oct 29, 2019
@lcawl lcawl deleted the fix-stack-urls branch October 29, 2019 21:37
jorgemarey pushed a commit to jorgemarey/beats that referenced this pull request Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants