Skip to content

Unskip close_* flaky tests#14067

Merged
ycombinator merged 2 commits intoelastic:masterfrom
ycombinator:fb-unskip-close-flaky-tests
Oct 18, 2019
Merged

Unskip close_* flaky tests#14067
ycombinator merged 2 commits intoelastic:masterfrom
ycombinator:fb-unskip-close-flaky-tests

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented Oct 15, 2019 •
edited
Loading

Follow up to #13907 as it might have resolved the flakiness in various close_* tests.

Resolves #12037.
Resolves #9214.

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Oct 15, 2019

jenkins, test this

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Oct 17, 2019

In both Travis CI and Jenkins CI, the close_removed and close_renamed tests unskipped in this PR have passed. Will retry CI a few more times to make sure there is no flakiness.

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Oct 17, 2019

jenkins, test this

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Oct 17, 2019

Again, in both Travis CI and Jenkins CI, the close_removed and close_renamed tests unskipped in this PR have passed. Retrying CI again to check for flakiness.

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Oct 17, 2019

jenkins, test this

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Oct 17, 2019

Once again, in both Travis CI and Jenkins CI, the close_removed and close_renamed tests unskipped in this PR have passed. Retrying CI one final time to check for flakiness.

@ycombinator ycombinator marked this pull request as ready for review October 17, 2019 19:37
@ycombinator ycombinator requested review from faec and jsoriano October 17, 2019 19:39
@ycombinator ycombinator added :Testing flaky-test Unstable or unreliable test cases. review v7.6.0 v8.0.0 labels Oct 17, 2019
@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Oct 17, 2019 •
edited
Loading

And again, in both Travis CI and Jenkins CI, the close_removed and close_renamed tests unskipped in this PR have passed. I feel comfortable saying these tests are no longer flaky and can be un-skipped now.

@ycombinator ycombinator requested a review from urso October 17, 2019 23:26
@ycombinator ycombinator merged commit d75ddac into elastic:master Oct 18, 2019
@ycombinator ycombinator deleted the fb-unskip-close-flaky-tests branch October 18, 2019 14:45
jorgemarey pushed a commit to jorgemarey/beats that referenced this pull request Jun 8, 2020
@ycombinator @jorgemarey
Unskip close_* flaky tests (elastic#14067)
4191d18 
* Unskip close_renamed test

* Unskip close_removed test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

@faec faec Awaiting requested review from faec

+1 more reviewer

@urso urso urso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test Unstable or unreliable test cases. review :Testing v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Filebeat] Flaky test test_harvester.Test.test_close_renamed [Filebeat] Flaky test test_harvester.Test.test_close_removed

3 participants

@ycombinator @jsoriano @urso