Do not check for alias when setup.ilm.check_exists is false#13848
Merged
cwurm merged 3 commits intoelastic:masterfrom Oct 3, 2019
Merged
Do not check for alias when setup.ilm.check_exists is false#13848cwurm merged 3 commits intoelastic:masterfrom
cwurm merged 3 commits intoelastic:masterfrom
Conversation
houndci-bot
reviewed
Sep 30, 2019
This was referenced Sep 30, 2019
urso
approved these changes
Sep 30, 2019
16909a1 to
2ece894
Compare
2ece894 to
7709689
Compare
cwurm
pushed a commit
that referenced
this pull request
Oct 14, 2019
Updates the writer role documentation based on #13847 and #13848. Also corrects some mistakes. 1. Changes `read from` to the correct `write to` (Beats does not read from indices). 2. Setting `setup.template.enabled` to `false` is no longer necessary after #13847. 3. Setting `setup.ilm.overwrite` to `false` is unnecessary if `setup.ilm.check_exists` is already `false` (even today). 4. Adds a note about only `monitor` and `create_doc` being always necessary, explicitly calling out the most secure configuration (following #13847 and #13848). 5. Correct what `monitor` is for: It's for checking things like cluster version and license, not "sending monitor info". 6. Replaces `manage_pipeline` with the read-only `cluster:admin/ingest/pipeline/get`. Unfortunately, there is no read-only cluster role for pipelines, so it requires this privilege. But better than the very permissive `manage_pipeline` that allows changing any pipeline. 7. Changes `index` to the more restrictive, append-only `create_doc` (introduced in elastic/elasticsearch#45806).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, setting
setup.ilm.check_existstofalseonly turns off checking if the ILM policy exists (GET _ilm/policy/{name}).This would expand that to also turn off checking if an alias exists (
GET _alias/{name}).The advantage would be that with
setup.ilm.check_existsset tofalsetheview_index_metadataprivilege would no longer be required, leaving only themonitorcluster privilege andcreateindex privileges as the only privileges that are always required to publish data from Beats.Instead of changing the behavior of
setup.ilm.check_existswe could also introduce a new configuration option. I like keeping it simple though, so only a single change to the config file is necessary for minimal privileges.This is one of three PRs to reduce the Beats privileges required in code and documentation:
Relates: #10241