[Heartbeat] Whitelist --index-management flag for heartbeat#13016
Merged
andrewvc merged 2 commits intoelastic:masterfrom Jul 23, 2019
Merged
[Heartbeat] Whitelist --index-management flag for heartbeat#13016andrewvc merged 2 commits intoelastic:masterfrom
andrewvc merged 2 commits intoelastic:masterfrom
Conversation
We received a bug report on [discuss](https://discuss.elastic.co/t/heartbeat-7-2-0-error-unknown-flag-index-management/191670) about this key being missing. It should have been added with elastic#11856 but was missed.
Contributor
|
Pinging @elastic/uptime |
simitt
reviewed
Jul 22, 2019
| setup.ResetFlags() | ||
| setup.Flags().Bool(cmd.IndexManagementKey, false, "Setup all components related to Elasticsearch index management, including template, ilm policy and rollover alias") | ||
| setup.Flags().Bool(cmd.TemplateKey, false, "Setup index template") | ||
| setup.Flags().Bool(cmd.ILMPolicyKey, false, "Setup ILM policy") |
Contributor
There was a problem hiding this comment.
I suggest to also deprecate --template and --ilm-policy by setting something like:
setup.Flags().MarkDeprecated(cmd.TemplateKey, fmt.Sprintf("use --%s instead", cmd.IndexManagementKey))
setup.Flags().MarkDeprecated(cmd.ILMPolicyKey, fmt.Sprintf("use --%s instead", cmd.IndexManagementKey))
Contributor
Author
|
Filebeat test failure is unrelated. Should be ready for final review. |
simitt
approved these changes
Jul 23, 2019
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Jul 23, 2019
…13016) * [Heartbeat] Whitelist --index-management flag for heartbeat We received a bug report on [discuss](https://discuss.elastic.co/t/heartbeat-7-2-0-error-unknown-flag-index-management/191670) about this key being missing. It should have been added with elastic#11856 but was missed. * Deprecate old keys (cherry picked from commit d43ec5e)
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Jul 23, 2019
…13016) * [Heartbeat] Whitelist --index-management flag for heartbeat We received a bug report on [discuss](https://discuss.elastic.co/t/heartbeat-7-2-0-error-unknown-flag-index-management/191670) about this key being missing. It should have been added with elastic#11856 but was missed. * Deprecate old keys (cherry picked from commit d43ec5e)
andrewvc
added a commit
that referenced
this pull request
Jul 23, 2019
…13042) * [Heartbeat] Whitelist --index-management flag for heartbeat We received a bug report on [discuss](https://discuss.elastic.co/t/heartbeat-7-2-0-error-unknown-flag-index-management/191670) about this key being missing. It should have been added with #11856 but was missed. * Deprecate old keys (cherry picked from commit d43ec5e)
andrewvc
added a commit
that referenced
this pull request
Jul 23, 2019
…13043) * [Heartbeat] Whitelist --index-management flag for heartbeat We received a bug report on [discuss](https://discuss.elastic.co/t/heartbeat-7-2-0-error-unknown-flag-index-management/191670) about this key being missing. It should have been added with #11856 but was missed. * Deprecate old keys (cherry picked from commit d43ec5e)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…13016) (elastic#13043) * [Heartbeat] Whitelist --index-management flag for heartbeat We received a bug report on [discuss](https://discuss.elastic.co/t/heartbeat-7-2-0-error-unknown-flag-index-management/191670) about this key being missing. It should have been added with elastic#11856 but was missed. * Deprecate old keys (cherry picked from commit cc196f8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We received a bug report on discuss about this key being missing. It should have been added with #11856 but was missed.
I haven't added tests here because this code is already very declarative. We mostly want to test the presence of this feature, not its implementation. While that has value here, the effort/benefit ratio here feels to me like something we can skip, which is what we did for @ruflin 's original PR.