Renaming anchor for beats common fields#12621
Merged
ycombinator merged 2 commits intoelastic:masterfrom Jun 20, 2019
ycombinator:update-beat-common-anchor
Merged
Renaming anchor for beats common fields#12621ycombinator merged 2 commits intoelastic:masterfrom ycombinator:update-beat-common-anchor
ycombinator merged 2 commits intoelastic:masterfrom
ycombinator:update-beat-common-anchor
Conversation
dedemorton
approved these changes
Jun 20, 2019
Contributor
dedemorton
left a comment
There was a problem hiding this comment.
LGTM. I have another PR I'm going to merge (as soon as I can get the CI to pass): #12242, so one of us will need to rebase.
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
* Renaming anchor for beats common fields * Removing extraneous file accidentally checked in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #12181, we're introducing a
beatMetricbeat module. The fields for this module are documented using the asciidoc block IDexported-fields-beat. However, this block ID is already taken by the documentation for fields that are common to all Beats.This PR proposes to resolve the naming conflict by renaming the Beats common fields' block ID to
exported-fields-beat-common.For more context, see #12181 (comment) and #12181 (comment).