Cherry-pick #11982 to 7.0: Change type from scaled_float to long and add format (#11982)#12158
Merged
kaiyan-sheng merged 3 commits intoelastic:7.0from May 16, 2019
kaiyan-sheng:backport_11982_7.0
Merged
Cherry-pick #11982 to 7.0: Change type from scaled_float to long and add format (#11982)#12158kaiyan-sheng merged 3 commits intoelastic:7.0from kaiyan-sheng:backport_11982_7.0
kaiyan-sheng merged 3 commits intoelastic:7.0from
kaiyan-sheng:backport_11982_7.0
Conversation
fearful-symmetry
approved these changes
May 15, 2019
Contributor
fearful-symmetry
left a comment
There was a problem hiding this comment.
LGTM. Stuff like this makes me wonder if there's any other metricsets floating around where we should be using the bytes format but we aren't.
Contributor
|
Also, CI should pass if you rebase? |
added 3 commits
May 15, 2019 16:13
* Change type from scaled_float to long and add format (cherry picked from commit 1b2613e)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ng and add format (elastic#11982) (elastic#12158) * Change type from scaled_float to long and add format (elastic#11982) (cherry picked from commit b97e5b7) * Move changelog to Bugfixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #11982 to 7.0 branch. Original message:
I'm gonna try this one more time... A lot of
scaled_floathere in aws module does not need to bescaled_float, alongtype should be sufficient here. Also, when I first started aws module, I didn't know about the definedformatin Elasticsearch. This PR also addsformat: bytesandformat: durationintofields.yml.(cherry picked from commit 1b2613e)