Document autodiscover dedot option#10938
Merged
kaiyan-sheng merged 3 commits intoelastic:masterfrom Mar 1, 2019
kaiyan-sheng:doc_docker_dedot
Merged
Document autodiscover dedot option#10938kaiyan-sheng merged 3 commits intoelastic:masterfrom kaiyan-sheng:doc_docker_dedot
kaiyan-sheng merged 3 commits intoelastic:masterfrom
kaiyan-sheng:doc_docker_dedot
Conversation
3 tasks
Contributor
Author
|
jenkins, test this please |
sayden
approved these changes
Feb 27, 2019
dedemorton
reviewed
Feb 27, 2019
Contributor
dedemorton
left a comment
There was a problem hiding this comment.
minor change, otherwise LGTM.
Contributor
There was a problem hiding this comment.
Suggested change
| `labels.dedot` is default to be `true` for docker autodiscover, which means dots in docker labels are replaced with '_' by default. | |
| `labels.dedot` defaults to `true` for docker autodiscover, which means that dots in docker labels are replaced with '_' by default. |
kaiyan-sheng
pushed a commit
that referenced
this pull request
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
labels.dedot is added in #10898 but not documented. This PR is to add the documentation for dedotting in docker autodiscover in 7.0 (default to true).