Revert "Introduce SkipAddHostName setting. (#10728)"#10769
Merged
urso merged 2 commits intoelastic:masterfrom Mar 8, 2019
Merged
Revert "Introduce SkipAddHostName setting. (#10728)"#10769urso merged 2 commits intoelastic:masterfrom
urso merged 2 commits intoelastic:masterfrom
Conversation
This reverts commit 72df5e5.
Member
|
I don't follow the reasoning here. Adding fields that aren't in the monitoring index template shouldn't affect anything other than adding unnecessary fields to the monitoring payload, as the template already includes |
Contributor
Author
|
@urso do you have any update on this? |
Contributor
Author
|
ok, please go ahead an merge this revert then any time (I don't seem to have permissions without an approval). |
fearful-symmetry
pushed a commit
to fearful-symmetry/beats
that referenced
this pull request
Mar 8, 2019
…10769) This reverts commit 72df5e5. @urso figured out that adding this `SkipAddHostName` flag changes the order in which processors are applied and also changes that the host name now gets added to beats that are using the `pipeline.New` method (e.g. xpack monitoring). Thus this commit will be reverted and another solution will be implemented that allows to not set the `host.name` for every beat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 72df5e5.
@urso figured out that adding this
SkipAddHostNameflag changes the order in which processors are applied and also changes that the host name now gets added to beats that are using thepipeline.Newmethod (e.g. xpack monitoring).Thus this commit will be reverted and another solution will be implemented that allows to not set the
host.namefor every beat.